-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: built-in bridge system test compatibility #2911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarhodes314
temporarily deployed
to
Test Pull Request
May 31, 2024 08:59 — with
GitHub Actions
Inactive
Robot Results
|
jarhodes314
temporarily deployed
to
Test Pull Request
June 6, 2024 12:41 — with
GitHub Actions
Inactive
This was referenced Jul 29, 2024
reubenmiller
force-pushed
the
enable-bridge-2
branch
from
July 29, 2024 20:41
f2eedee
to
59d2b2f
Compare
reubenmiller
temporarily deployed
to
Test Pull Request
July 29, 2024 20:41 — with
GitHub Actions
Inactive
reubenmiller
had a problem deploying
to
Test Pull Request
July 29, 2024 20:51 — with
GitHub Actions
Failure
reubenmiller
temporarily deployed
to
Test Pull Request
July 29, 2024 20:57 — with
GitHub Actions
Inactive
reubenmiller
force-pushed
the
enable-bridge-2
branch
from
July 30, 2024 17:56
48a9843
to
72ddf64
Compare
reubenmiller
had a problem deploying
to
Test Pull Request
July 30, 2024 17:56 — with
GitHub Actions
Failure
reubenmiller
temporarily deployed
to
Test Pull Request
July 30, 2024 18:26 — with
GitHub Actions
Inactive
reubenmiller
force-pushed
the
enable-bridge-2
branch
from
July 30, 2024 18:54
af48e50
to
6b564c1
Compare
reubenmiller
temporarily deployed
to
Test Pull Request
July 30, 2024 18:54 — with
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
reubenmiller
force-pushed
the
enable-bridge-2
branch
from
July 30, 2024 19:53
6b564c1
to
fee7374
Compare
reubenmiller
temporarily deployed
to
Test Pull Request
July 30, 2024 19:53 — with
GitHub Actions
Inactive
reubenmiller
force-pushed
the
enable-bridge-2
branch
from
July 30, 2024 20:41
fee7374
to
86bd3d2
Compare
reubenmiller
temporarily deployed
to
Test Pull Request
July 30, 2024 20:41 — with
GitHub Actions
Inactive
reubenmiller
changed the title
Enable built-in bridge for testing
fix: built-in bridge handing of QoS 1 messages and system tests
Jul 30, 2024
reubenmiller
temporarily deployed
to
Test Pull Request
July 30, 2024 21:07 — with
GitHub Actions
Inactive
reubenmiller
changed the title
fix: built-in bridge handing of QoS 1 messages and system tests
test: Enable built-in bridge for testing
Jul 31, 2024
Signed-off-by: James Rhodes <[email protected]>
Signed-off-by: Reuben Miller <[email protected]>
reubenmiller
force-pushed
the
enable-bridge-2
branch
from
July 31, 2024 08:18
1ee16dc
to
224c182
Compare
reubenmiller
temporarily deployed
to
Test Pull Request
July 31, 2024 08:19 — with
GitHub Actions
Inactive
reubenmiller
temporarily deployed
to
Test Pull Request
July 31, 2024 08:28 — with
GitHub Actions
Inactive
reubenmiller
changed the title
test: Enable built-in bridge for testing
test: built-in bridge system test verification
Jul 31, 2024
reubenmiller
changed the title
test: built-in bridge system test verification
test: built-in bridge system test compatibility
Jul 31, 2024
reubenmiller
temporarily deployed
to
Test Pull Request
July 31, 2024 08:54 — with
GitHub Actions
Inactive
reubenmiller
force-pushed
the
enable-bridge-2
branch
from
July 31, 2024 09:50
e761ba5
to
224c182
Compare
reubenmiller
temporarily deployed
to
Test Pull Request
July 31, 2024 09:50 — with
GitHub Actions
Inactive
reubenmiller
requested review from
reubenmiller,
albinsuresh,
Bravo555,
gligorisaev and
a team
as code owners
July 31, 2024 09:51
reubenmiller
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Verify that all system tests can pass when switching to the built-in bridge by default, however the default bridge type will be set to mosquitto until the built-in bridge stability can be verified.
The CI runner was used to verify that all system tests pass when set to
builtin
ormosquitto
in the system tests (via the bootstrap.sh` script), below are the results:builtin
bridge - PASSED RUN https://github.com/thin-edge/thin-edge.io/actions/runs/10176783954/job/28147947095?pr=2911mosquitto
bridge - (Check the status of this PR to view the test)Below are the details about the system test changes:
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments