Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: built-in bridge system test compatibility #2911

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

jarhodes314
Copy link
Contributor

@jarhodes314 jarhodes314 commented May 31, 2024

Proposed changes

Verify that all system tests can pass when switching to the built-in bridge by default, however the default bridge type will be set to mosquitto until the built-in bridge stability can be verified.

The CI runner was used to verify that all system tests pass when set to builtin or mosquitto in the system tests (via the bootstrap.sh` script), below are the results:

Below are the details about the system test changes:

  • Support easily switching bridge type (e.g. builtin or mosquitto) in the system test bootstrap.sh script (but default is still using the mosquitto bridge for now)
  • Fix system tests which made some assumptions about which bridge was being used

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Contributor

github-actions bot commented May 31, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
486 0 2 486 100 1h18m43.215891s

@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request June 6, 2024 12:41 — with GitHub Actions Inactive
@reubenmiller reubenmiller self-assigned this Jul 23, 2024
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 29, 2024 20:41 — with GitHub Actions Inactive
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 29, 2024 20:57 — with GitHub Actions Inactive
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 30, 2024 18:26 — with GitHub Actions Inactive
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 30, 2024 18:54 — with GitHub Actions Inactive
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.1%. Comparing base (e419058) to head (86bd3d2).
Report is 51 commits behind head on main.

Files Patch % Lines
crates/extensions/tedge_mqtt_bridge/src/lib.rs 25.0% 6 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
crates/extensions/tedge_mqtt_bridge/src/lib.rs 88.3% <25.0%> (-1.2%) ⬇️

... and 44 files with indirect coverage changes

@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 30, 2024 19:53 — with GitHub Actions Inactive
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 30, 2024 20:41 — with GitHub Actions Inactive
@reubenmiller reubenmiller added the theme:mqtt Theme: mqtt and mosquitto related topics label Jul 30, 2024
@reubenmiller reubenmiller changed the title Enable built-in bridge for testing fix: built-in bridge handing of QoS 1 messages and system tests Jul 30, 2024
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 30, 2024 21:07 — with GitHub Actions Inactive
@reubenmiller reubenmiller changed the title fix: built-in bridge handing of QoS 1 messages and system tests test: Enable built-in bridge for testing Jul 31, 2024
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 31, 2024 08:19 — with GitHub Actions Inactive
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 31, 2024 08:28 — with GitHub Actions Inactive
@reubenmiller reubenmiller changed the title test: Enable built-in bridge for testing test: built-in bridge system test verification Jul 31, 2024
@reubenmiller reubenmiller changed the title test: built-in bridge system test verification test: built-in bridge system test compatibility Jul 31, 2024
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 31, 2024 08:54 — with GitHub Actions Inactive
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 31, 2024 09:50 — with GitHub Actions Inactive
@reubenmiller reubenmiller marked this pull request as ready for review July 31, 2024 09:51
Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Jul 31, 2024
Merged via the queue into thin-edge:main with commit e4fdb00 Jul 31, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:mqtt Theme: mqtt and mosquitto related topics theme:testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants