Wrap ActiveRecord configuration into initializer #432
Conversation
`Rails.application` is not available when the railties are collected,
so we move the ActiveRecord configuration into the initializer phase.
```
NoMethodError: undefined method `config' for nil:NilClass (NoMethodError)
application.config
^^^^^^^
/project/app/vendor/bundle/ruby/3.2.0/gems/railties-7.0.8/lib/rails.rb:47:in `configuration'
/project/app/vendor/bundle/ruby/3.2.0/gems/factory_bot_rails-6.4.0/lib/factory_bot_rails/railtie.rb:25:in `block in <class:Railtie>'
```
|
APPROUVED |
|
This should fix #426 |
…gets merged and released as a gem
Lock factory_bot_rails to 6.2.x until thoughtbot/factory_bot_rails#432 gets merged and released as a gem
|
I just ran into this as well after a This looks good! Merge please? |
|
thanks, works perfectly well … any plans to merge and release it? |
|
This bug is making CI builds across the planet fail, a quick release would be great. I'm curious how the original bug passed factory_bot_rails's own CI build, and wonder if there's a test that could have caught the bug, that should be added. |
|
This resolves the issue for me as well. |
There's a bug in the latest version of `factory_bot_rails`: thoughtbot/factory_bot_rails#433 There's also a fix that hasn't been merged or released yet: thoughtbot/factory_bot_rails#432 I'm setting the `Gemfile` to specifically avoid those buggy versions so that we can get `depfu` un-blocked with keeping gems up to date.
* Avoid buggy versions of factory_bot_rails There's a bug in the latest version of `factory_bot_rails`: thoughtbot/factory_bot_rails#433 There's also a fix that hasn't been merged or released yet: thoughtbot/factory_bot_rails#432 I'm setting the `Gemfile` to specifically avoid those buggy versions so that we can get `depfu` un-blocked with keeping gems up to date. * dang linter
|
I would like to see this shipped. And as @jrochkind said
Thanks |
|
Hi, thanks for tracking this down. I cannot work on this bug this week, but I do I have time to merge PRs and cut releases. If someone could add a test to this, that'd be the last step we need. Thank you! |
This is well known issue. We should prefer to code that reference active record only when it's already lazy loaded. It can break other gems initializing process Related: - rails/rails#46567 - paper-trail-gem/paper_trail@fc6c5f6 (inspiration) - thoughtbot/factory_bot_rails#432 Fix: DatabaseCleaner#89
This is well known issue. We should prefer to code that reference active record only when it's already lazy loaded. It can break other gems initializing process Related: - rails/rails#46567 - paper-trail-gem/paper_trail@fc6c5f6 (inspiration) - thoughtbot/factory_bot_rails#432 Fix: DatabaseCleaner#89
|
I cherry picked this commit and added a non-regression test. I also make sure we are good on Rails 7.1 too. |
There was a problem hiding this comment.
@leoarnold
Thank you for your PR!
This diff (test codes) might help to merge this PR (ref #432 (comment)):
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -2,6 +2,10 @@
ENV["RAILS_ENV"] = "test"
+require "active_record"
+
+class ActiveRecord::Base; end
+
require "factory_bot_rails"
require "fake_app"There are gem monkey-patched to ActiveRecord. With these, ActiveRecord might be loaded before Rails.application is initialized. This is the cause of #426 .
This code snippet reproduces ActiveRecord being loaded before Rails.application is initialized.
Rails.applicationis not available when the railties are collected, so we move the ActiveRecord configuration into the initializer phase.