Add discount icon with discount package in contracts table #3392
Conversation
amiraabouhadid
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
|
can we add some spaces between the icon and the text ? as Ehab did here #2477 (comment) |
|
Also, I have a gold discount while my current balance is zero and the contract is in grace period. Is this right? I've waited till a new billing cycle is entered.
|
|
I founded my account yesterday with 10K TFT, but the package doesn't changed |
funded my account with more than 1 million tft and still have the same discount levels after more than 12h |
| async getDiscountPackage(options: GetDiscountPackageOptions): Promise<DiscountLevel> { | ||
| const gqlClient = new Graphql(options.graphqlURL); | ||
| const body = `query getConsumption($contractId: BigInt!){ | ||
| contractBillReports(where: {contractID_eq: $contractId}, limit: 1 ) { |
There was a problem hiding this comment.
i think this will make the first discount package will always displayed, i suggest to remove limit and get the last element in the list this may fix the issue
this happens in smaller screen sizes, yes. |
|
@0oM4R started out with a default package after funding account with 1M TFT, package changed to gold in less than 3hrs |
i had no problem listing them before today so definitely gridproxy issue |
|
Text overlap on smaller screens |
|
UI changed to |
|
|
|
updated |
|
created a vm with a wallet that has 10M TFT, will update the comment later with the results |
|
|
|
now discount shows none transfared 4000TFT and after refresh got silver |
| async getDiscountPackage(options: GetDiscountPackageOptions): Promise<DiscountLevel> { | ||
| const gqlClient = new Graphql(options.graphqlURL); | ||
|
|
||
| const body = `query getConsumption($contractId: BigInt!){ |
There was a problem hiding this comment.
I notice that we can add order to the request body; i think this will be better
|
|
||
| <v-tooltip bottom color="primary" close-delay="100" v-if="item.discountPackage" cols="2"> | ||
| <template v-slot:activator="{ props }"> | ||
| <v-icon class="scale_beat mr-2" color="warning" v-bind="props">mdi-brightness-percent</v-icon> |
There was a problem hiding this comment.
i think we should remove the mr-2 no need for it
| v-if="item?.consumption !== 0 && item?.consumption !== undefined" | ||
| class="d-flex justify-center align-center" | ||
| > | ||
| <p class="mr-2" cols="8">{{ item.consumption.toFixed(3) }} TFT/hour</p> |
There was a problem hiding this comment.
using text-no-wrap may fix this issue.
Description
Changes
Related Issues
#2477
Tested Scenarios
Documentation PR
For UI changes, Please provide the Documetation PR on info_grid
Checklist