-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add discount icon with discount package in contracts table #3392
Open
amiraabouhadid
wants to merge
16
commits into
development
Choose a base branch
from
dev_add_discount_contracts
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
074753a
added discount icon with discount package fetched from graphql
amiraabouhadid bbc16ec
add discountPackage tooltip condition to display only when a package …
amiraabouhadid 91b942a
adjust tooltip alignment
amiraabouhadid ec2747c
adjust billing rate flex
amiraabouhadid 88888eb
Merge branch 'development' into dev_add_discount_contracts
amiraabouhadid 7be9a76
add spacing between icon and billing rate
amiraabouhadid 618ace6
Merge branch 'development' into dev_add_discount_contracts
amiraabouhadid 8da4c15
Merge branch 'development' into dev_add_discount_contracts
amiraabouhadid 9a18f62
use last discount in billreports instead of first
amiraabouhadid 7356136
Merge branch 'development' into dev_add_discount_contracts
amiraabouhadid 654ffd2
Merge branch 'development' into dev_add_discount_contracts
amiraabouhadid 3e41e62
Merge branch 'development' into dev_add_discount_contracts
amiraabouhadid 779ccb5
Merge branch 'development' into dev_add_discount_contracts
amiraabouhadid 5f63dc6
update ui
amiraabouhadid 30ef189
Merge branch 'development' into dev_add_discount_contracts
amiraabouhadid 6f61764
remove flex column in small screen sizes
amiraabouhadid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,9 +36,23 @@ | |
</template> | ||
|
||
<template #[`item.consumption`]="{ item }"> | ||
<p v-if="item?.consumption !== 0 && item?.consumption !== undefined"> | ||
{{ item.consumption.toFixed(3) }} TFT/hour | ||
</p> | ||
<div | ||
v-if="item?.consumption !== 0 && item?.consumption !== undefined" | ||
class="d-flex justify-center align-center" | ||
> | ||
<p class="mr-2" cols="8">{{ item.consumption.toFixed(3) }} TFT/hour</p> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
<v-tooltip bottom color="primary" close-delay="100" v-if="item.discountPackage" cols="2"> | ||
<template v-slot:activator="{ props }"> | ||
<v-icon class="scale_beat mr-2" color="warning" v-bind="props">mdi-brightness-percent</v-icon> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think we should remove the mr-2 no need for it |
||
</template> | ||
|
||
<span> | ||
{{ item.discountPackage }} | ||
</span> | ||
</v-tooltip> | ||
</div> | ||
|
||
<p v-else>No Data Available</p> | ||
</template> | ||
|
||
|
@@ -289,7 +303,7 @@ | |
|
||
<script lang="ts" setup> | ||
// Import necessary types and libraries | ||
import { ContractStates, type GridClient, type OverdueDetails } from "@threefold/grid_client"; | ||
import { ContractStates, discountPackages, type GridClient, type OverdueDetails } from "@threefold/grid_client"; | ||
import { type Contract, ContractState, type NodeStatus } from "@threefold/gridproxy_client"; | ||
import { TFChainError } from "@threefold/tfchain_client"; | ||
import { DeploymentKeyDeletionError } from "@threefold/types"; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that we can add order to the request body; i think this will be better