-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix adding worker with mycelium to k8s #3565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the PR description to include tested scenarios.
and brief about the original couase of the issue will be great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we should do that, I see it implemented that way in many scripts.. @AhmedHanafy725 what do you think? |
it's required for the ssh package, but it should be mentioned clearly in the docs that we should generate an ed25519 sshkey in the correct path. Please create an issue for it |
its mentioned in the tests here to use ed25519 sshkey: |
Description
myceliumNetworkSeed.seed
is existed..skip
fromadd worker
test case.Changes
Tested Scenarios
yarn test tests/modules/kubernetes.test.ts
Related Issues
add_worker
in the same script as deploy k8s with Mycelium option is added #3509Checklist