Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding worker with mycelium to k8s #3565

Closed
wants to merge 2 commits into from

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Oct 30, 2024

Description

  • Check if myceliumNetworkSeed.seed is existed.
  • Remove .skip from add worker test case.

Changes

image

Tested Scenarios

  • Go to the Grid Client package
  • Run yarn test tests/modules/kubernetes.test.ts
  • All cases should pass

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the PR description to include tested scenarios.
and brief about the original couase of the issue will be great

@samaradel samaradel requested a review from 0oM4R November 17, 2024 09:42
@xmonader xmonader requested a review from ramezsaeed November 18, 2024 11:39
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are still failing
Screenshot from 2024-11-21 13-19-42

@samaradel samaradel marked this pull request as draft November 25, 2024 14:53
@samaradel samaradel marked this pull request as ready for review December 2, 2024 12:14
@samaradel
Copy link
Contributor Author

image
works now

@samaradel samaradel requested a review from 0oM4R December 2, 2024 12:15
@maayarosama
Copy link
Contributor

I get the following error while trying to run the test, I suggest that it might be a good idea to to read the network, mnemonics and ssh key straight from the config file
Screenshot from 2024-12-05 14-57-52

@samaradel
Copy link
Contributor Author

I get the following error while trying to run the test, I suggest that it might be a good idea to to read the network, mnemonics and ssh key straight from the config file Screenshot from 2024-12-05 14-57-52

I'm not sure if we should do that, I see it implemented that way in many scripts.. @AhmedHanafy725 what do you think?

@AhmedHanafy725
Copy link
Contributor

I get the following error while trying to run the test, I suggest that it might be a good idea to to read the network, mnemonics and ssh key straight from the config file Screenshot from 2024-12-05 14-57-52

I'm not sure if we should do that, I see it implemented that way in many scripts.. @AhmedHanafy725 what do you think?

it's required for the ssh package, but it should be mentioned clearly in the docs that we should generate an ed25519 sshkey in the correct path. Please create an issue for it

@ramezsaeed
Copy link
Contributor

ramezsaeed commented Dec 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants