Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mycelium IP column in workers table #3590

Closed

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Nov 5, 2024

Description

  • Add the MyCelium IP column in the worker's table.
  • Include myCelium in the worker deployment object.
  • Add Created At and Health columns.

Changes

Screencast.from.25-11-24.16.21.46.webm

Tested Scenarios

  • Go to Caprover solution
  • Deploy instance with worker and mycelium enabled
  • List the deployments
  • View the worker's table, the mycelium column should be there

Scenarios update

  • Create more than two workers and check that all have the mycelium IP column.
  • Create with planetary and no mycelium and check nothing in the mycelium column.
  • Delete a worker, add it again, and ensure mycelium ip changes.

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

- Add MyCelium IP column in workers table
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the PR description to include the tested scenarios

@samaradel samaradel requested a review from 0oM4R November 17, 2024 09:32
@0oM4R
Copy link
Contributor

0oM4R commented Nov 18, 2024

Screenshot from 2024-11-18 12-48-51
Screenshot from 2024-11-18 12-48-37

I think there are some inconsistency between tables

  • contract id
  • health
  • cpu
  • cost
  • memory
  • disk
  • created at

not sure what is the required fields on both tables, it is not mentioned in the issue

0oM4R

This comment was marked as outdated.

@0oM4R 0oM4R dismissed their stale review November 18, 2024 10:53

by mistake

Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2024-11-18 12-48-51
Screenshot from 2024-11-18 12-48-37

I think there are some inconsistency between tables

  • contract id
  • health
  • cpu
  • cost
  • memory
  • disk
  • created at

not sure what is the required fields on both tables, it is not mentioned in the issue

@xmonader xmonader requested a review from ramezsaeed November 18, 2024 11:38
@samaradel
Copy link
Contributor Author

@0oM4R never mind, open an issue :)

Copy link
Contributor

@ramezsaeed ramezsaeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add theses test scenarios:

  • create more than two workers and check all has the mycelium ip column.
  • create with planetary and no mycelium and check nothing in mycelium column.
  • delete a worker and add it again and make sure mycelium ip changed.

@AhmedHanafy725
Copy link
Contributor

Screenshot from 2024-11-18 12-48-51 Screenshot from 2024-11-18 12-48-37

I think there are some inconsistency between tables

  • contract id
  • health
  • cpu
  • cost
  • memory
  • disk
  • created at

not sure what is the required fields on both tables, it is not mentioned in the issue

@samaradel This is within the issue requirement, so no need for a new issue, and should be handled here.

@samaradel samaradel marked this pull request as draft November 25, 2024 12:08
@samaradel
Copy link
Contributor Author

Screencast from 25-11-24 16:21:46.webm
columns updated

@samaradel samaradel marked this pull request as ready for review November 25, 2024 14:22
@samaradel samaradel requested a review from maayarosama December 5, 2024 11:16
@amiraabouhadid
Copy link
Contributor

amiraabouhadid commented Dec 9, 2024

when i try to create a third worker
first atempt
image
second attempt
image
creating two workers beforehand worked fine with correct mycelium ip column

Screenshot from 2024-12-09 12-34-44

@samaradel
Copy link
Contributor Author

@amiraabouhadid I see it's blocked on #3565 please review it first.

@samaradel samaradel marked this pull request as draft December 9, 2024 11:02
@AhmedHanafy725 AhmedHanafy725 deleted the branch development_2.7 December 15, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants