-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mycelium IP column in workers table #3590
Conversation
- Add MyCelium IP column in workers table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the PR description to include the tested scenarios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0oM4R never mind, open an issue :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to add theses test scenarios:
- create more than two workers and check all has the mycelium ip column.
- create with planetary and no mycelium and check nothing in mycelium column.
- delete a worker and add it again and make sure mycelium ip changed.
@samaradel This is within the issue requirement, so no need for a new issue, and should be handled here. |
Screencast from 25-11-24 16:21:46.webm |
…og.vue Co-authored-by: Amira <[email protected]>
packages/playground/src/components/manage_caprover_worker_dialog.vue
Outdated
Show resolved
Hide resolved
…og.vue Co-authored-by: Mayar Osama Fouad Ali <[email protected]>
@amiraabouhadid I see it's blocked on #3565 please review it first. |
Description
Created At
andHealth
columns.Changes
Screencast.from.25-11-24.16.21.46.webm
Tested Scenarios
Caprover
solutionScenarios update
Related Issues
Checklist