fix(multigrid_ndt_omp_impl): changed counting timing and break confition for nr_iterations
#23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed counting timing and break confition for
nr_iterations
to be the same as the original pcl ndt.hpp.
https://github.com/PointCloudLibrary/pcl/blob/424c1c6a0ca97d94ca63e5daff4b183a4db8aae4/registration/include/pcl/registration/impl/ndt.hpp#L73-L180
Evaluation
I degraded the accuracy of the localization and set NDT to run at its maximum iterations, then ran Autoware.
(The value of the nr_iterations result is now also logged.)
Before
The maximum value for
ndt_result.iteration_num
is 32.After
The maximum value for
ndt_result.iteration_num
is 30.