Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: caluculate nearest voxel score each point #66

Merged
merged 9 commits into from
Sep 17, 2024

Conversation

SaltUhey
Copy link

@SaltUhey SaltUhey commented Sep 12, 2024

Description

To visualize matching score each point, a function is implemented to output a point cloud containing the value of the score of each point.

This score is the highest value of the neighboring voxels of each point.

Related links

autoware_universe

@SakodaShintaro
Copy link

@SaltUhey
The CI check "pre-commit" failed.
Could you apply clang-format to new code?

Signed-off-by: yuhei <[email protected]>
Copy link

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
I left some comments. Please reply to them. 🙏

include/multigrid_pclomp/multigrid_ndt_omp.h Outdated Show resolved Hide resolved
include/pclomp/ndt_struct.hpp Outdated Show resolved Hide resolved
include/multigrid_pclomp/multigrid_ndt_omp.h Outdated Show resolved Hide resolved
Copy link

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your correction.
I have confirmed that the logging_simulator works well and the mean error of /localization/kinematic_state is almost the same as before.
Looks Good To Me

@SakodaShintaro SakodaShintaro merged commit 2c8b6ef into tier4:tier4/main Sep 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants