Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace target cloud updated false #75

Conversation

kimurariku
Copy link

@kimurariku kimurariku commented Jan 8, 2025

PR Type

  • Improvement

Related Links

Internal Link

Description

The perpose of this PR is to incorporate changes for improving memory usage of NDT Scan Matcher.

Review Procedure

Confirmed that this commit is in the diff between chore/replace_target_cloud and fix/target_cloud_updated_false.
image

Verification of changes has been discussed in this ticket

f557f39
This commit has been captured by cherry-pick.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code follows [coding guidelines][coding-guidelines]
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows [coding guidelines][coding-guidelines]
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes
  • (When added something to .repos) Check if proper access rights are set.
    You can check the latest permission setting status of each repository [here][github-repository-status].
    If the repository permissions are insufficient, you need to add the permissions according to [this][repository-permission-setting-flow].

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write [release notes][release-notes]

CI Checks

  • vcs import: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@kimurariku kimurariku requested a review from asa-naki January 8, 2025 05:39
Copy link

@asa-naki asa-naki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This change results reduce memomy usage in this ticket

@kimurariku kimurariku merged commit c822084 into feat/x1eve/reduce_memory_usage Jan 8, 2025
16 checks passed
@kimurariku kimurariku deleted the chore/replace_target_cloud_updated_false branch January 8, 2025 09:31
@kimurariku kimurariku mentioned this pull request Jan 9, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants