-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hesai ptp setup parameters #110
Conversation
Signed-off-by: amc-nu <[email protected]>
Signed-off-by: amc-nu <[email protected]>
Signed-off-by: amc-nu <[email protected]>
…t load Signed-off-by: amc-nu <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
========================================
+ Coverage 6.58% 8.35% +1.76%
========================================
Files 136 67 -69
Lines 10987 8232 -2755
Branches 869 859 -10
========================================
- Hits 724 688 -36
+ Misses 9677 6960 -2717
+ Partials 586 584 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: amc-nu <[email protected]>
Signed-off-by: amc-nu <[email protected]>
Signed-off-by: amc-nu <[email protected]>
Signed-off-by: amc-nu <[email protected]>
Signed-off-by: amc-nu <[email protected]>
Signed-off-by: amc-nu <[email protected]>
Signed-off-by: amc-nu <[email protected]>
I tested PTP operation and the xml launchfiles. The Python launchfile does not appear to work. It does not set the rotation speed, which has a default as a non-integer causing a launch error. I will submit a PR for the rotation error issue, but the python launcher should probably access more setting (like rotation speed, destination IP). |
nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: amc-nu <[email protected]>
Signed-off-by: amc-nu <[email protected]>
Signed-off-by: amc-nu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
PR Type
Description
Add support to the hesai hw interface to setup the Lidar's PTP profile.
Review Procedure
You can now set up the PTP profile using the following arguments in the XML and Python launch files.
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks