arch/arm64/imx9: Add trdc support #280
Conversation
| * | ||
| ****************************************************************************/ | ||
|
|
||
| static void imx9_ele_sendmsg(struct ele_msg *msg) |
There was a problem hiding this comment.
Olikos tää jo toisaalla? Tuo ele support?
There was a problem hiding this comment.
Ei oo, sitä ei varmaan välttämättä nyt oikeen muuten tarvikkaan tässä bootloaderissa.
|
|
||
| struct trdc_glbac_config trdc_w_mrc_glbac[] = | ||
| { | ||
| { 0, 0, SP(RWX) | SU(RWX) | NP(RWX) | NU(RWX) }, /* MRC0 */ |
There was a problem hiding this comment.
./nxstyle varmaa herjaa extra spaceista
|
|
||
| struct trdc_glbac_config trdc_n_mrc_glbac[] = | ||
| { | ||
| { 0, 0, SP(RWX) | SU(RWX) | NP(RWX) | NU(RWX) }, |
|
|
||
| struct trdc_glbac_config trdc_n_mrc_glbac[] = | ||
| { | ||
| { 0, 0, SP(RWX) | SU(RWX) | NP(RWX) | NU(RWX) }, |
There was a problem hiding this comment.
Hiusten halkomista, mutta yllä lienee ylimääräinen space (ei mee nätisti alla olevan kanssa)
|
|
||
| /* aonmix */ | ||
|
|
||
| struct trdc_glbac_config trdc_a_mbc_glbac[] = |
There was a problem hiding this comment.
Are the constants in the struct board specific? I.e. should be under board..? Also, if they are constants, should be const?
There was a problem hiding this comment.
Yes they are kind of board specific, and changing structs to const means almost re-writing .c file, but it can be done of course. Maybe we can include imx9_trdc_config.h to board.h
There was a problem hiding this comment.
#include "imx9_trdc.h"
#include <arch/board/imx9_trdc_config.h> This seems to work, but then this patch need to be splitted so that _config.h goes to board git tree
joukkone
force-pushed
the
imx9_trdc
branch
2 times, most recently
from
843dd9e to
83e8050
Compare
|
|
||
| int imx9_trdc_init(void); | ||
|
|
||
| #endif /* __ARCH_ARM64_SRC_IMX9_IMX9_TRDC_H */ |
arch/arm64/src/imx9/imx9_trdc.c
Outdated
| int ret; | ||
| imx9_init_mu(); | ||
|
|
||
| ret = imx9_release_rdc(0); |
There was a problem hiding this comment.
just pass the rdc_id directly, the switch-case in release_rdc burns my eyes
Trdc is configured in EL3 bootloader Clock pre-initialization is also executed there. Signed-off-by: Jouni Ukkonen <[email protected]>
Trdc is configured in EL3 bootloader
Clock pre-initialization is also executed there.
Summary
Impact
Testing