Add a small SLEW rate for SSRC X500 frame ESC control #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been observed that With higher frequency control loop the ESCs start behaving badly if PWM pulse width changes too rapidly. Take the motors moment of inertia into account and just restrict the change Signed-off-by: Jukka Laitinen <[email protected]>
joukkone
approved these changes
Dec 19, 2024
|
I'll wait on this until the same thing is tested on T-motor as well, so we can merge those at the same |
|
It turned out that this fix is not needed after all. The issue was root caused elsewhere, and needs a code fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been observed that With higher frequency control loop the ESCs start behaving badly if PWM pulse width changes too rapidly. Take the motors moment of inertia into account and just restrict the change