dr-autosync: add recover timeout #6295

disksing · 2023-04-10T09:33:15Z

What problem does this PR solve?

Issue Number: close #4939.

What is changed and how does it work?

add a configuration item to delay dr state switch from async to sync-recover

Check List

Tests

Unit test

Release note

None.

Signed-off-by: disksing <[email protected]>

ti-chi-bot · 2023-04-10T09:33:17Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

lhy1024
nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2023-04-10T09:49:04Z

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.51%. Comparing base (2c07c24) to head (2daf7e1).
Report is 615 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6295      +/-   ##
==========================================
+ Coverage   74.48%   74.51%   +0.03%     
==========================================
  Files         446      446              
  Lines       48435    48441       +6     
==========================================
+ Hits        36076    36095      +19     
+ Misses       9182     9159      -23     
- Partials     3177     3187      +10

Flag	Coverage Δ
unittests	`74.51% <75.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

ti-chi-bot · 2023-08-02T08:45:10Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

close tikv#6988, close tikv#7016 Signed-off-by: husharp <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

lhy1024 · 2023-11-09T05:39:25Z

pkg/replication/replication_mode.go

@@ -477,7 +488,7 @@ func (m *ModeManager) tickUpdateState() {
 			m.drSwitchToAsync(storeIDs[primaryUp])
 		}
 	case drStateAsync:
-		if canSync {
+		if canSync && m.drDurationSinceAsyncStart() > m.config.DRAutoSync.WaitRecoverTimeout.Duration {


Is this config only used to switch from async to syncRecover?

lhy1024 · 2023-11-09T05:39:49Z

pkg/replication/replication_mode.go

@@ -262,7 +263,8 @@ func (m *ModeManager) drSwitchToAsyncWithLock(availableStores []uint64) error {
 		log.Warn("failed to switch to async state", zap.String("replicate-mode", modeDRAutoSync), errs.ZapError(err))
 		return err
 	}
-	dr := drAutoSyncStatus{State: drStateAsync, StateID: id, AvailableStores: availableStores}
+	now := time.Now()


Do we need to pick it to 6.5 and other branches?

need cherry-pick 6.5. i have added the label

nolouch · 2023-11-10T03:20:49Z

/merge

ti-chi-bot · 2023-11-10T03:20:51Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-11-10T03:20:52Z

This pull request has been accepted and is ready to merge.

Commit hash: 4cfcdad

disksing · 2023-11-10T03:41:01Z

/merge

ti-chi-bot · 2023-11-10T03:41:04Z

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-11-10T04:04:19Z

In response to a cherrypick label: new pull request created to branch release-6.5: #7347.

ref tikv#4399 Signed-off-by: husharp <[email protected]>

close #4939 Signed-off-by: husharp <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

ref tikv#4399 Signed-off-by: husharp <[email protected]>

ti-chi-bot · 2024-11-06T08:10:51Z

In response to a cherrypick label: new pull request created to branch release-7.1: #8775.

ti-chi-bot · 2024-11-06T08:10:51Z

In response to a cherrypick label: new pull request created to branch release-7.5: #8776.

ref tikv#4399 Signed-off-by: husharp <[email protected]>

close #4939 Signed-off-by: husharp <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

close #4939 Signed-off-by: husharp <[email protected]> Co-authored-by: disksing <[email protected]>

dr-autosync: add recover timeout

b686692

Signed-off-by: disksing <[email protected]>

ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 10, 2023

Merge branch 'master' into wait-recover-timeout

c8ae8ef

ti-chi-bot requested review from nolouch and rleungx April 10, 2023 09:33

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2023

Merge branch 'master' into wait-recover-timeout

7591211

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 14, 2023

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2023

coordinator: use a healthy region count to start coordinator (tikv#7044)

62f711c

close tikv#6988, close tikv#7016 Signed-off-by: husharp <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2023

Merge branch 'master' into wait-recover-timeout

4cfcdad

lhy1024 approved these changes Nov 9, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 9, 2023

disksing added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Nov 9, 2023

nolouch approved these changes Nov 10, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 10, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 10, 2023

Merge branch 'master' into wait-recover-timeout

2daf7e1

disksing removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2023

ti-chi-bot bot merged commit 0c35227 into tikv:master Nov 10, 2023
26 checks passed

disksing deleted the wait-recover-timeout branch November 10, 2023 04:03

ti-chi-bot mentioned this pull request Nov 10, 2023

dr-autosync: add recover timeout (#6295) #7347

Merged

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 10, 2023

dr-autosync: add recover timeout (tikv#6295)

1fb4741

ref tikv#4399 Signed-off-by: husharp <[email protected]>

ti-chi-bot bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Nov 6, 2024

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 6, 2024

dr-autosync: add recover timeout (tikv#6295)

adf0f22

ref tikv#4399 Signed-off-by: husharp <[email protected]>

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 6, 2024

dr-autosync: add recover timeout (tikv#6295)

1b0355f

ref tikv#4399 Signed-off-by: husharp <[email protected]>

This was referenced Nov 6, 2024

dr-autosync: add recover timeout (#6295) #8775

Merged

dr-autosync: add recover timeout (#6295) #8776

Merged

ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2024

dr-autosync: add recover timeout (#6295) (#8776)

0035391

close #4939 Signed-off-by: husharp <[email protected]> Co-authored-by: disksing <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dr-autosync: add recover timeout #6295

dr-autosync: add recover timeout #6295

disksing commented Apr 10, 2023 •

edited by JmPotato

Loading

ti-chi-bot commented Apr 10, 2023 •

edited by ti-chi-bot bot

Loading

codecov bot commented Apr 10, 2023 •

edited

Loading

ti-chi-bot bot commented Aug 2, 2023

lhy1024 Nov 9, 2023

disksing Nov 9, 2023

lhy1024 Nov 9, 2023

disksing Nov 9, 2023

nolouch commented Nov 10, 2023

ti-chi-bot bot commented Nov 10, 2023

ti-chi-bot bot commented Nov 10, 2023

disksing commented Nov 10, 2023

ti-chi-bot bot commented Nov 10, 2023

ti-chi-bot commented Nov 10, 2023

ti-chi-bot commented Nov 6, 2024

ti-chi-bot commented Nov 6, 2024

dr-autosync: add recover timeout #6295

dr-autosync: add recover timeout #6295

Conversation

disksing commented Apr 10, 2023 • edited by JmPotato Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot commented Apr 10, 2023 • edited by ti-chi-bot bot Loading

codecov bot commented Apr 10, 2023 • edited Loading

Codecov Report

ti-chi-bot bot commented Aug 2, 2023

lhy1024 Nov 9, 2023

Choose a reason for hiding this comment

disksing Nov 9, 2023

Choose a reason for hiding this comment

lhy1024 Nov 9, 2023

Choose a reason for hiding this comment

disksing Nov 9, 2023

Choose a reason for hiding this comment

nolouch commented Nov 10, 2023

ti-chi-bot bot commented Nov 10, 2023

ti-chi-bot bot commented Nov 10, 2023

disksing commented Nov 10, 2023

ti-chi-bot bot commented Nov 10, 2023

ti-chi-bot commented Nov 10, 2023

ti-chi-bot commented Nov 6, 2024

ti-chi-bot commented Nov 6, 2024

disksing commented Apr 10, 2023 •

edited by JmPotato

Loading

ti-chi-bot commented Apr 10, 2023 •

edited by ti-chi-bot bot

Loading

codecov bot commented Apr 10, 2023 •

edited

Loading