mcs: support alloc ID for scheduling server #6984
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
the
release-note-none
ti-chi-bot
bot
added
the
size/XL
pkg/mcs/scheduling/server/server.go
Outdated
| go s.updateMemberLoop() | ||
| } | ||
|
|
||
| func (s *Server) updateMemberLoop() { |
There was a problem hiding this comment.
What about naming it updateAPIServerMember?
| // InitLogger initializes the logger for test. | ||
| func InitLogger(cfg *tso.Config) (err error) { | ||
| // InitSchedulingLogger initializes the logger for test. | ||
| func InitSchedulingLogger(cfg *sc.Config) (err error) { |
There was a problem hiding this comment.
Does resource manager server need similar function?
There was a problem hiding this comment.
We need further refactoring to merge them. For now, we don't use it.
Codecov Report
@@ Coverage Diff @@
## master #6984 +/- ##
==========================================
- Coverage 74.29% 74.20% -0.09%
==========================================
Files 434 435 +1
Lines 46062 46171 +109
==========================================
+ Hits 34223 34263 +40
- Misses 8827 8883 +56
- Partials 3012 3025 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
pkg/mcs/scheduling/server/cluster.go
Outdated
| c.checkMembershipCh <- struct{}{} | ||
| return 0, errors.New("API server leader is not found") | ||
| } | ||
| resp, err := cli.AllocID(context.Background(), &pdpb.AllocIDRequest{Header: &pdpb.RequestHeader{ClusterId: c.clusterID}}) |
There was a problem hiding this comment.
What about using a passed-in context by calling AllocID(ctx)?
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 309aecc
|
ti-chi-bot
bot
added
the
status/can-merge
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
ti-chi-bot
bot
removed
the
status/can-merge
|
/merge |
|
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: ec167bc
|
ti-chi-bot
bot
added
the
status/can-merge
ref tikv#5839 Signed-off-by: Ryan Leung <[email protected]>
What problem does this PR solve?
Issue Number: Ref #5839.
What is changed and how does it work?
We need to allocate ID for building the operator in the scheduling server. But the ID is maintained by the API server, so we have to call RPC to get the ID.
Check List
Tests
Release note