Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dashboard): update version to v2023.09.11.1 (#7065) #7084

Merged
merged 5 commits into from
Sep 14, 2024
Merged

chore(dashboard): update version to v2023.09.11.1 (#7065) #7084

merged 5 commits into from
Sep 14, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7065

What problem does this PR solve?

Issue Number: Close #7066

What is changed and how does it work?

Related tidb-dashboard release: pingcap/tidb-dashboard#1588

1. security: improve tidb-dashboard login security, encrypt the login password to avoid transport plain text (required for 6.5 version)
2. debug-api: support pagination for ddl history for debug-api
3. keyvisual: use scanRegions instead of fetch all regions (required for 6.5 version)
4. refine execution plan, now it can be showed as table style

Release note

None.

Test

make pd-server
tiup playground v6.5.4 --tiflash 0 --pd.binpath /mnt/bao/codes/work/pd/bin/pd-server

image

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 12, 2023
Merged
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Sep 12, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Sep 12, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2023
@baurine baurine mentioned this pull request Sep 12, 2023
Closed
@baurine
Copy link
Contributor

baurine commented Sep 22, 2023

hi guys, we need to resolve the conflicts and merge the PR, thanks~

@baurine
Copy link
Contributor

baurine commented Sep 22, 2023

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@baurine you're not a member of org tikv

@HuSharp HuSharp force-pushed the cherry-pick-7065-to-release-6.1 branch from 3802dd6 to 4348a77 Compare September 22, 2023 07:02
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 22, 2023
@HuSharp HuSharp self-requested a review September 22, 2023 07:05
@HuSharp HuSharp force-pushed the cherry-pick-7065-to-release-6.1 branch from 25aa7c3 to e30d09b Compare September 22, 2023 07:29
@HuSharp
fix
43a9fb0 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the cherry-pick-7065-to-release-6.1 branch from e30d09b to 43a9fb0 Compare September 22, 2023 08:33
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

see 27 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@baurine
Copy link
Contributor

baurine commented Sep 25, 2023 •
edited
Loading

Test

tiup playground v6.1.7 --tiflash 0 --pd.binpath /mnt/bao/codes/work/pd/bin/pd-server

image

/cc @HuSharp

@HuSharp HuSharp self-assigned this Oct 7, 2023
HuSharp
HuSharp reviewed Oct 7, 2023
View reviewed changes
server/schedule/filter/filters.go
@@ -18,7 +18,7 @@ import (
"fmt"
"strconv"

"github.com/golang/protobuf/proto"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update because https://github.com/tikv/pd/actions/runs/6271999405/job/17032664879?pr=7084#step:5:187

HuSharp
HuSharp reviewed Oct 7, 2023
View reviewed changes
server/server.go
@@ -30,7 +30,7 @@ import (
"time"

"github.com/coreos/go-semver/semver"
"github.com/golang/protobuf/proto"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2023
@HuSharp
fix
705725e 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the cherry-pick-7065-to-release-6.1 branch from d90a427 to 705725e Compare October 7, 2023 03:09
@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Sep 13, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 13, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 14, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-13 08:22:20.225251484 +0000 UTC m=+603809.965675423: ☑️ agreed by rleungx.
  • 2024-09-14 03:13:07.483085923 +0000 UTC m=+671657.223509905: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit abc78cd into tikv:release-6.1 Sep 14, 2024
18 checks passed
@HuSharp HuSharp deleted the cherry-pick-7065-to-release-6.1 branch September 14, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp left review comments

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees

@HuSharp HuSharp

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @baurine @lhy1024 @rleungx @HuSharp