Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_control: dynamically change the controller config (#7042) #7495

Merged
merged 10 commits into from
Dec 7, 2023

Merge branch 'release-7.1' into cherry-pick-7042-to-release-7.1

06d80ef
Select commit
Loading
Failed to load commit list.
Merged

resource_control: dynamically change the controller config (#7042) #7495

Merge branch 'release-7.1' into cherry-pick-7042-to-release-7.1
06d80ef
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 7, 2023 in 1s

74.86% (-0.08%) compared to 0b048b1

View this Pull Request on Codecov

74.86% (-0.08%) compared to 0b048b1

Details

Codecov Report

Attention: 107 lines in your changes are missing coverage. Please review.

Comparison is base (0b048b1) 74.93% compared to head (06d80ef) 74.86%.

Files Patch % Lines
client/resource_group/controller/controller.go 60.58% 41 Missing and 13 partials ⚠️
pkg/mcs/resource_manager/server/manager.go 53.65% 12 Missing and 7 partials ⚠️
client/meta_storage_client.go 37.50% 7 Missing and 3 partials ⚠️
pkg/mcs/resource_manager/server/apis/v1/api.go 43.75% 6 Missing and 3 partials ⚠️
client/resource_group/controller/util.go 42.85% 6 Missing and 2 partials ⚠️
client/resource_manager_client.go 50.00% 3 Missing and 2 partials ⚠️
client/resource_group/controller/testutil.go 0.00% 1 Missing ⚠️
server/grpc_service.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-7.1    #7495      +/-   ##
===============================================
- Coverage        74.93%   74.86%   -0.08%     
===============================================
  Files              409      410       +1     
  Lines            41366    41513     +147     
===============================================
+ Hits             30998    31077      +79     
- Misses            7658     7699      +41     
- Partials          2710     2737      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov