Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client/controller: add logs and export more information in throttled error #8028

Merged
merged 2 commits into from
Apr 7, 2024
Merged

client/controller: add logs and export more information in throttled error #8028

merged 2 commits into from
Apr 7, 2024

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Apr 7, 2024

What problem does this PR solve?

Issue Number: Ref #7509

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 7, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 7, 2024
@ti-chi-bot ti-chi-bot bot requested review from disksing and lhy1024 April 7, 2024 08:11
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 7, 2024
@nolouch nolouch changed the title client/controller: add more logs client/controller: add logs and export more information in Throttled error Apr 7, 2024
@nolouch nolouch changed the title client/controller: add logs and export more information in Throttled error client/controller: add logs and export more information in throttled error Apr 7, 2024
@nolouch nolouch requested review from CabinfeverB and HuSharp and removed request for disksing and lhy1024 April 7, 2024 08:12
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2024
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 7, 2024
@nolouch
Copy link
Contributor Author

nolouch commented Apr 7, 2024

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 7, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 7, 2024

This pull request has been accepted and is ready to merge.

Commit hash: c31f91c

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit cbde636 into tikv:master Apr 7, 2024
22 checks passed
@nolouch nolouch deleted the add-logs branch June 5, 2024 08:33
@nolouch nolouch added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. and removed needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jun 5, 2024
@nolouch
Copy link
Contributor Author

nolouch commented Jun 5, 2024

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8255.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 5, 2024
@nolouch @ti-chi-bot
This is an automated cherry-pick of tikv#8028
14135bd 
ref tikv#7509

Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 5, 2024
@nolouch @ti-chi-bot
This is an automated cherry-pick of tikv#8028
982bf3c 
ref tikv#7509

Signed-off-by: ti-chi-bot <[email protected]>
This was referenced Jun 5, 2024
Merged
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #8256.

ti-chi-bot bot added a commit that referenced this pull request Jun 19, 2024
@ti-chi-bot @nolouch @ti-chi-bot
client/controller: add logs and export more information in throttled …
2807999 
…error (#8028) (#8255)

ref #7509

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: nolouch <[email protected]>

Co-authored-by: ShuNing <[email protected]>
Co-authored-by: nolouch <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nolouch @ti-chi-bot @CabinfeverB @HuSharp