Add 'test_author' 'make' target (and alias 'atest') #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkeenan
force-pushed
the
author-testing-20210430
branch
from
60f07bc
to
37816dc
Compare
|
I had hoped to have Travis and AppVeyor run 'make test_author' but have not yet figured out how to update the configuration files. So that will be handled in a separate pull request. |
Add envvar NYTPROF_AUTHOR_TESTING. 'make test_author' and 'make atest' will set this envvar true, thereby causing certain unit tests within the test suite and/or test files to run only when needed by NYTProf developers. Accordingly, move 90-pod.t back into t/ from xt/, but have this run only when NYTPROF_AUTHOR_TESTING is set. This should have a favorable impact on timbunce#174.
These 2 NYTPROF_* targets don't need to be defined outside the scope of a particular 'make' target. Defining them may interfere with, e.g., .appveyor.yml.
jkeenan
force-pushed
the
author-testing-20210430
branch
from
37816dc
to
14899c9
Compare
timbunce
approved these changes
May 2, 2021
|
Merged into master in commit 3864290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add envvar NYTPROF_AUTHOR_TESTING. 'make test_author' and 'make atest'
will set this envvar true, thereby causing certain unit tests within the
test suite and/or test files to run only when needed by NYTProf
developers.
Accordingly, move 90-pod.t back into t/ from xt/, but have this run only
when NYTPROF_AUTHOR_TESTING is set.
This should have a favorable impact on
#174.