Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stack: introduce hook.downloadEnabled boolean to include/exclude hook download job #86

Closed
wants to merge 1 commit into from
Closed

stack: introduce hook.downloadEnabled boolean to include/exclude hook download job #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tinkerbell/stack/templates/hook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{{- if .Values.stack.hook.enabled }}
{{- if .Values.stack.hook.downloadEnabled }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could combine both these into a single statement.

Suggested change
{{- if .Values.stack.hook.downloadEnabled }}
{{- if and .Values.stack.hook.enabled .Values.stack.hook.downloadEnabled }}

---
apiVersion: v1
kind: ConfigMap
Expand Down Expand Up @@ -39,7 +40,7 @@ spec:
containers:
- name: download-hook
image: {{ .Values.stack.hook.image }}
command: ["/script/entrypoint.sh"]
command: [ "/script/entrypoint.sh" ]
volumeMounts:
- mountPath: /output
name: hook-artifacts
Expand All @@ -55,4 +56,5 @@ spec:
configMap:
defaultMode: 0700
name: download-hook
{{- end }}
{{- end }}
1 change: 1 addition & 0 deletions tinkerbell/stack/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ stack:
# downloadURL only works with the > 0.8.1 Hook release because
# previous Hook versions didn't provide a checksum file.
downloadURL: https://github.com/tinkerbell/hook/releases/download/latest
downloadEnabled: true # Set to false if you somehow download Hook manually; if set to True will include a download Job
kubevip:
enabled: true
name: kube-vip
Expand Down
Loading