stack: introduce hook.downloadEnabled boolean to include/exclude hook download job #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… download job - sometimes we don't want to download the default hook binaries - this is separate from stack.hook.enabled, which controls the hostPath etc Signed-off-by: Ricardo Pardini <[email protected]>
rpardini
force-pushed
the
stack-add-hook-downloadEnabled
branch
from
7634324
to
fd93cb3
Compare
jacobweinstock
approved these changes
Mar 28, 2024
| @@ -1,4 +1,5 @@ | |||
| {{- if .Values.stack.hook.enabled }} | |||
| {{- if .Values.stack.hook.downloadEnabled }} | |||
There was a problem hiding this comment.
you could combine both these into a single statement.
Suggested change
| {{- if .Values.stack.hook.downloadEnabled }} | |
| {{- if and .Values.stack.hook.enabled .Values.stack.hook.downloadEnabled }} |
jacobweinstock
approved these changes
Jul 19, 2024
|
Hey @rpardini, mergify is not able to merge this PR. Mind updating the PR to allow edits? reference: https://github.com/tinkerbell/charts/pull/86/checks?check_run_id=27673082786 "This pull request cannot be embarked for merge Pull request can't be updated with latest base branch changes Mergify needs the author permission to update the base branch of the pull request. |
|
I no longer have an use-case for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stack: introduce hook.downloadEnabled boolean to include/exclude hook download job