Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mentions demo to behave more consistently #3511

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

TheSpyder
Copy link
Member

@TheSpyder TheSpyder commented Nov 18, 2024

Ticket: n/a, discovered by @lostkeys in slack

Site: Staging branch

Changes:

  • Sort the list of usernames on load. This doesn't guarantee a sorted result, because we use an object store, but I don't really want to sort on every search
  • Fix the case insensitive name match code, which was only lowercasing the query term. The result was what a user would consider completely unpredictable behaviour

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.
  • modules/ROOT/nav.adoc has been updated (if applicable).
  • Included a release note entry for any New product features.
  • If this is a minor release, updated productminorversion in antora.yml and added new supported versions entry in modules/ROOT/partials/misc/supported-versions.adoc.

Review:

  • Documentation Team Lead has reviewed

@TheSpyder TheSpyder changed the title Fix demo to behave more consistently Fix mentions demo to behave more consistently Nov 18, 2024
Copy link
Contributor

@kemister85 kemister85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix.

Copy link

@LewisAtTiny LewisAtTiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!!

@kemister85 kemister85 merged commit adbf25c into tinymce/7 Nov 18, 2024
5 checks passed
@kemister85 kemister85 deleted the hotfix/7/mentions-demo-fix branch November 18, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants