Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mentions demo to behave more consistently #3511

Merged
merged 1 commit into from
Nov 18, 2024

Fixed user comparison in the fetch function, and sorted the names

a9b4f90
Select commit
Loading
Failed to load commit list.
Merged

Fix mentions demo to behave more consistently #3511

Fixed user comparison in the fetch function, and sorted the names
a9b4f90
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Nov 18, 2024 in 0s

5 / 5 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Sort the list of usernames on load. This doesn't guarantee a sorted result, because we use an object store, but I don't really want to sort on every search Incomplete
Fix the case insensitive name match code, which was only lowercasing the query term. The result was what a user would consider completely unpredictable behaviour Incomplete
Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/. Completed
modules/ROOT/nav.adoc has been updated (if applicable). Completed
Included a release note entry for any New product features. Completed
If this is a minor release, updated productminorversion in antora.yml and added new supported versions entry in modules/ROOT/partials/misc/supported-versions.adoc. Completed
Documentation Team Lead has reviewed Completed