Skip to content

expose functions to refresh an embedded key #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025

Conversation

andrewkmin
Copy link
Contributor

@andrewkmin andrewkmin commented Apr 2, 2025

$title

Accompanying tkhq/sdk change: tkhq/sdk#571

Screen.Recording.2025-04-02.at.3.31.24.PM.mov

@andrewkmin andrewkmin changed the title update iframe stamper to have methods to expose functions to refresh an embedded key Apr 2, 2025
auth/index.html Outdated
@@ -1077,6 +1090,7 @@ <h2>Message log</h2>
},
false
);
// also, reset isn't a completely accurate name for this
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this comment but others may not? You can complete the thought by saying "because this only clears the key, without regenerating a fresh one"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@andrewkmin andrewkmin merged commit 347b24a into main Apr 3, 2025
6 checks passed
@andrewkmin andrewkmin deleted the andrew/iframe-reset-embedded-key branch April 3, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants