update iframe stamper to have methods to refresh an embedded key #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ee90d60:
|
andrewkmin
changed the title
r-n-o
reviewed
Apr 2, 2025
r-n-o
reviewed
Apr 2, 2025
packages/iframe-stamper/src/index.ts
Outdated
Comment on lines
56
to
57
| // Event sent by the parent to reset the iframe's embedded key. | ||
| // Value: none |
There was a problem hiding this comment.
Worth adding a comment here to say that this doesn't actually reset the key, it simply clears it.
r-n-o
reviewed
Apr 2, 2025
packages/iframe-stamper/src/index.ts
Outdated
| GetEmbeddedPublicKey = "GET_EMBEDDED_PUBLIC_KEY", | ||
| // Event sent by the parent to reset the iframe's embedded key. | ||
| // Value: none | ||
| ResetEmbeddedKey = "RESET_EMBEDDED_KEY", |
There was a problem hiding this comment.
What do you think about naming this ClearEmbeddedKey instead? That'll make the comment more understandable, and SDK clients won't need to comment their code to explain that ResetEmbeddedKey actually only clears it. We stop the bleeding here :D
turnekybc
approved these changes
Apr 3, 2025
r-n-o
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
$title
Accompying
tkhq/frameschange (with demo vid): tkhq/frames#67How I Tested These Changes
Screen.Recording.2025-04-03.at.12.36.11.PM.mov
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.