-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding type hints for segmentation #351
Adding type hints for segmentation #351
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.5.x #351 +/- ##
=============================================
+ Coverage 56.35% 56.40% +0.05%
=============================================
Files 16 16
Lines 3384 3388 +4
=============================================
+ Hits 1907 1911 +4
Misses 1477 1477
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
I agree, and although we will definitely do this as part of the conversion to xarray it may be worthwhile to do a couple of passes first, both to fix the worst code smells and break things down into more manageable sized functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…ype_hints # Conflicts: # tobac/segmentation.py
As part of my broader type hinting efforts (see #74, #341, #337), I've gone through quickly and added type hints to Segmentation. I have avoided type hints on the wrapper functions, as I think we need to ultimately decide what to do with them at some later stage.
As an aside (and I should make an issue for this), Segmentation (especially after the PBC changes, sorry about that) is in desperate need of a deep refactor.