Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): update edgeless color palette #9243

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Dec 23, 2024

Closes: BS-1475 BS-1803 BS-1804 BS-1815

What's Changed

  • refactor EdgelessLineWidthPanel component, the previous width is fixed and cannot be used in the new design
  • refactor EdgelessColorPanel and EdgelessColorButton components, make them simple and reusable
  • delete redundant EdgelessOneRowColorPanel component
  • unity and update color palette, if the previously set color is not in the latest color palette, the custom color button will be selected

Copy link
Contributor Author

fundon commented Dec 23, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the test Related to test cases label Dec 23, 2024
@fundon fundon changed the title feat(blocksuite): update edgeless color palette feat: update edgeless color palette Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 66.03774% with 36 lines in your changes missing coverage. Please review.

Project coverage is 51.53%. Comparing base (6b1865f) to head (a5641ae).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...lock/edgeless/components/panel/line-width-panel.ts 51.51% 14 Missing and 2 partials ⚠️
...ck/edgeless/components/toolbar/shape/shape-menu.ts 0.00% 8 Missing ⚠️
...t-block/edgeless/components/color-picker/button.ts 12.50% 7 Missing ⚠️
...oot-block/edgeless/components/panel/color-panel.ts 81.25% 3 Missing ⚠️
.../edgeless/components/color-picker/custom-button.ts 50.00% 1 Missing ⚠️
...ock/widgets/element-toolbar/change-shape-button.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9243      +/-   ##
==========================================
+ Coverage   51.51%   51.53%   +0.01%     
==========================================
  Files        2148     2148              
  Lines       97111    97004     -107     
  Branches    16260    16243      -17     
==========================================
- Hits        50029    49992      -37     
+ Misses      45694    45628      -66     
+ Partials     1388     1384       -4     
Flag Coverage Δ
server-test 78.13% <ø> (+0.06%) ⬆️
unittest 30.93% <65.09%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 6df1229 to 3620993 Compare December 23, 2024 03:33
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch 2 times, most recently from 2d5f677 to 82cbe9e Compare December 23, 2024 04:25
@fundon fundon changed the title feat: update edgeless color palette feat(blocksuite): update edgeless color palette Dec 23, 2024
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch 12 times, most recently from 8149a23 to 9e11e04 Compare December 23, 2024 06:51
@fundon fundon marked this pull request as ready for review December 23, 2024 08:27
@fundon fundon requested a review from a team as a code owner December 23, 2024 08:27
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 9e11e04 to aa795bd Compare December 23, 2024 14:37
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch 4 times, most recently from 89db587 to 76b6292 Compare December 27, 2024 08:00
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch 6 times, most recently from f7793db to bbd7b50 Compare December 27, 2024 10:24
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch 13 times, most recently from e75596a to 353f01d Compare December 29, 2024 10:27
Copy link

graphite-app bot commented Dec 30, 2024

Merge activity

Closes: [BS-1475](https://linear.app/affine-design/issue/BS-1475/颜色主题更新) [BS-1803](https://linear.app/affine-design/issue/BS-1803/fill-color色板影响的yuan素) [BS-1804](https://linear.app/affine-design/issue/BS-1804/border-color色板影响的yuan素) [BS-1815](https://linear.app/affine-design/issue/BS-1815/连线文字配色略瞎)

### What's Changed

* refactor `EdgelessLineWidthPanel` component, the previous width is fixed and cannot be used in the new design
* refactor `EdgelessColorPanel` and `EdgelessColorButton` components, make them simple and reusable
* delete redundant `EdgelessOneRowColorPanel` component
* unity and update color palette, if the previously set color is not in the latest color palette, the custom color button will be selected
@Saul-Mirone Saul-Mirone force-pushed the fundon/12_23_update_edgeless_color_palette branch from 353f01d to a5641ae Compare December 30, 2024 03:36
@graphite-app graphite-app bot merged commit a5641ae into canary Dec 30, 2024
61 checks passed
@graphite-app graphite-app bot deleted the fundon/12_23_update_edgeless_color_palette branch December 30, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants