Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): store real color values in edgeless #9254

Merged

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Dec 23, 2024

What's Changed!

  • adds theme type: ThemeSchema
  • adds default theme: DefaultTheme
  • stores real color values

Copy link
Contributor Author

fundon commented Dec 23, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from fb93b95 to 04cf141 Compare December 23, 2024 14:13
@github-actions github-actions bot added the test Related to test cases label Dec 23, 2024
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch 2 times, most recently from 0ca415e to 4dbadb3 Compare December 23, 2024 14:33
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 9e11e04 to aa795bd Compare December 23, 2024 14:37
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch 3 times, most recently from 9fec4a5 to 44d739d Compare December 23, 2024 14:40
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from aa795bd to 67fb7ca Compare December 23, 2024 14:40
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from 44d739d to cd3ec87 Compare December 23, 2024 14:40
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 48.84615% with 133 lines in your changes missing coverage. Please review.

Project coverage is 51.46%. Comparing base (a5641ae) to head (b9f2650).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ock/widgets/element-toolbar/change-shape-button.ts 49.01% 22 Missing and 4 partials ⚠️
...widgets/element-toolbar/change-connector-button.ts 11.53% 23 Missing ⚠️
...ock/widgets/element-toolbar/change-brush-button.ts 0.00% 15 Missing ⚠️
...ock/widgets/element-toolbar/change-frame-button.ts 12.50% 14 Missing ⚠️
...-block/widgets/element-toolbar/change-text-menu.ts 0.00% 9 Missing ⚠️
...k/edgeless/components/color-picker/color-picker.ts 0.00% 8 Missing ⚠️
...ot-block/edgeless/components/color-picker/utils.ts 12.50% 7 Missing ⚠️
...ck/edgeless/components/toolbar/shape/shape-menu.ts 0.00% 7 Missing ⚠️
...lock/widgets/element-toolbar/change-note-button.ts 53.84% 5 Missing and 1 partial ⚠️
...t-block/edgeless/components/color-picker/button.ts 50.00% 3 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9254      +/-   ##
==========================================
- Coverage   51.53%   51.46%   -0.08%     
==========================================
  Files        2148     2150       +2     
  Lines       97004    96993      -11     
  Branches    16243    16201      -42     
==========================================
- Hits        49992    49913      -79     
- Misses      45628    45699      +71     
+ Partials     1384     1381       -3     
Flag Coverage Δ
server-test 78.13% <ø> (ø)
unittest 30.88% <41.15%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch 5 times, most recently from d690394 to 74b4433 Compare December 24, 2024 04:41
@fundon fundon changed the title feat: store real color values in edgeless feat(editor): store real color values in edgeless Dec 24, 2024
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 67fb7ca to 4eb17c1 Compare December 24, 2024 05:17
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch 5 times, most recently from add24e1 to 93d7525 Compare December 24, 2024 06:14
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 4eb17c1 to 49033af Compare December 24, 2024 06:24
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch 3 times, most recently from 9c7fac8 to 9907200 Compare December 24, 2024 06:44
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 992604d to affc667 Compare December 29, 2024 06:52
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from 05d71f3 to 1c71bac Compare December 29, 2024 06:52
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from affc667 to f83138d Compare December 29, 2024 06:59
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from 1c71bac to 9f4210d Compare December 29, 2024 06:59
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from f83138d to a1d9dd1 Compare December 29, 2024 07:11
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from 9f4210d to bff3563 Compare December 29, 2024 07:12
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from a1d9dd1 to 8021f28 Compare December 29, 2024 07:46
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from bff3563 to 8ce4753 Compare December 29, 2024 07:46
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 8021f28 to 8059ba4 Compare December 29, 2024 08:09
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from 8ce4753 to fada2b8 Compare December 29, 2024 08:09
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 8059ba4 to 0d127bf Compare December 29, 2024 09:35
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from fada2b8 to b81b21c Compare December 29, 2024 09:35
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from 0d127bf to e75596a Compare December 29, 2024 09:56
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from b81b21c to 0961700 Compare December 29, 2024 09:56
@fundon fundon force-pushed the fundon/12_23_update_edgeless_color_palette branch from e75596a to 353f01d Compare December 29, 2024 10:27
@fundon fundon force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch 4 times, most recently from 274e805 to 7278bf0 Compare December 30, 2024 02:45
Copy link

graphite-app bot commented Dec 30, 2024

Merge activity

### What's Changed!

* adds theme type: `ThemeSchema`
* adds default theme: `DefaultTheme`
* stores real color values
@Saul-Mirone Saul-Mirone force-pushed the fundon/12_23_update_edgeless_color_palette branch from 353f01d to a5641ae Compare December 30, 2024 03:36
@Saul-Mirone Saul-Mirone force-pushed the fundon/12_23_store_real_color_values_in_edgeless branch from 7278bf0 to b9f2650 Compare December 30, 2024 03:37
Base automatically changed from fundon/12_23_update_edgeless_color_palette to canary December 30, 2024 03:50
@graphite-app graphite-app bot merged commit b9f2650 into canary Dec 30, 2024
61 checks passed
@graphite-app graphite-app bot deleted the fundon/12_23_store_real_color_values_in_edgeless branch December 30, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants