Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: add initialize func to SubnerRegistrator #107

Merged
merged 6 commits into from
Sep 12, 2023
Merged

Conversation

JDawg287
Copy link
Member

@JDawg287 JDawg287 commented Sep 7, 2023

Description

This PR adds an admin parameter for the SubnetRegistrator.sol smart contract via an initialize function.
The rationale is to have a constant address for the SubnetRegistrator.sol smart contract while having access control.

Fixes TP-700

Additions and Changes

  • Revert changes in the deploy.ts scripts introduced in chore: add AC for registering/removing subnets #102
  • Added a parameter admin in the initialize func of the SubnerRegistrator.sol smart contract
  • Added deploy-subnet-registrator.ts script
  • Made changes to the register-subnet.ts script to allow the sequencer/validator to register a subnet

PR Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@JDawg287 JDawg287 self-assigned this Sep 7, 2023
Signed-off-by: Jawad Tariq <[email protected]>
@JDawg287 JDawg287 changed the title feat: add deployer param to SubnetRegistrator constructor feat: add admin param to SubnetRegistrator constructor Sep 7, 2023
@JDawg287 JDawg287 force-pushed the feature/TP-700 branch 3 times, most recently from 3f0d496 to 5ee88fe Compare September 8, 2023 06:35
@JDawg287 JDawg287 changed the title feat: add admin param to SubnetRegistrator constructor feat: add initialize func to SubnerRegistrator Sep 11, 2023
@sebastiendan sebastiendan merged commit 3cb4662 into main Sep 12, 2023
13 of 14 checks passed
@sebastiendan sebastiendan deleted the feature/TP-700 branch September 12, 2023 06:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants