-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPT-1478] Add enableResetSearch prop to Select and QB #4075
[CPT-1478] Add enableResetSearch prop to Select and QB #4075
Conversation
🦋 Changeset detectedLatest commit: 410a2c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Greetings from FX team, @angelinastavniiciuc 👋 Thank you so much for contributing 🙇 We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme! What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉 🙏 please, help us improve, rate your contributing experience after merge |
@toptal-bot run package:alpha-release |
Your alpha package is ready 🎉 |
@toptal-anvil ping reviewers |
@toptal-anvil ping reviewers |
@toptal-bot run package:alpha-release |
Your alpha package is ready 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, thanks for the contribution, I left one more small comment about changeset, but other than that I don't see any problem 🙇 💪
@toptal-bot run package:alpha-release |
Your alpha package is ready 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good.
@toptal-bot run package:alpha-release |
Your alpha package is ready 🎉 |
20c8adb
to
0fdf3a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, everything works as expected
2cf855f
to
410a2c8
Compare
CPT-1478
Description
In this PR we provided new prop enableResetChange for Select component in order to be able to reset value from the search input and this prop was added to Multiselect component for QB
How to test
Search behavior
example check if new exampleSearch with input reset
appearedScreenshots
Development checks
props
in component with documentationexamples
for componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?