Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPT-1478] Add enableResetSearch prop to Select and QB #4075

Merged

Conversation

angelinastavniiciuc
Copy link
Contributor

@angelinastavniiciuc angelinastavniiciuc commented Jan 2, 2024

CPT-1478

Description

In this PR we provided new prop enableResetChange for Select component in order to be able to reset value from the search input and this prop was added to Multiselect component for QB

How to test

  • Temploy
  • Open temploy
  • Go to Select story
  • Under Search behavior example check if new example Search with input reset appeared
  • Make sure that reset is working as expected (when something is typed clicking on reset button clears the value)

Screenshots

Before. After.
image image

Development checks

Breaking change

  • n/a codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@angelinastavniiciuc angelinastavniiciuc added the Feature New feature or request label Jan 2, 2024
@angelinastavniiciuc angelinastavniiciuc self-assigned this Jan 2, 2024
@angelinastavniiciuc angelinastavniiciuc requested a review from a team as a code owner January 2, 2024 15:59
Copy link

changeset-bot bot commented Jan 2, 2024

🦋 Changeset detected

Latest commit: 410a2c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@toptal/picasso Minor
@toptal/picasso-query-builder Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the contribution DO NOT ADD MANUALLY label Jan 2, 2024
@toptal-devbot
Copy link
Collaborator

Greetings from FX team, @angelinastavniiciuc 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

@angelinastavniiciuc
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@53.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-761a51db7.28+761a51db7
yarn add @toptal/picasso@42.2.5-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-761a51db7.1+761a51db7
yarn add @toptal/picasso-charts@56.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-761a51db7.28+761a51db7
yarn add @toptal/picasso-codemod@5.6.4-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-761a51db7.78+761a51db7
yarn add @toptal/picasso-forms@66.1.2-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-761a51db7.23+761a51db7
yarn add @toptal/picasso-pictograms@2.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-761a51db7.148+761a51db7
yarn add @toptal/picasso-provider@3.4.3-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-761a51db7.20+761a51db7
yarn add @toptal/picasso-query-builder@1.2.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-761a51db7.16+761a51db7
yarn add @toptal/picasso-rich-text-editor@10.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-761a51db7.28+761a51db7
yarn add @toptal/picasso-shared@13.1.3-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-761a51db7.1+761a51db7
yarn add @toptal/picasso-tailwind@1.0.2-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-761a51db7.8+761a51db7

@angelinastavniiciuc
Copy link
Contributor Author

@toptal-anvil ping reviewers

@angelinastavniiciuc
Copy link
Contributor Author

@toptal-anvil ping reviewers

@angelinastavniiciuc
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@53.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-e982ffb02.29+e982ffb02
yarn add @toptal/picasso@42.2.5-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-e982ffb02.2+e982ffb02
yarn add @toptal/picasso-charts@56.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-e982ffb02.29+e982ffb02
yarn add @toptal/picasso-codemod@5.6.4-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-e982ffb02.79+e982ffb02
yarn add @toptal/picasso-forms@66.1.2-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-e982ffb02.24+e982ffb02
yarn add @toptal/picasso-pictograms@2.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-e982ffb02.149+e982ffb02
yarn add @toptal/picasso-provider@3.4.3-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-e982ffb02.21+e982ffb02
yarn add @toptal/picasso-query-builder@1.2.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-e982ffb02.17+e982ffb02
yarn add @toptal/picasso-rich-text-editor@10.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-e982ffb02.29+e982ffb02
yarn add @toptal/picasso-shared@13.1.3-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-e982ffb02.2+e982ffb02
yarn add @toptal/picasso-tailwind@1.0.2-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-e982ffb02.9+e982ffb02

Copy link
Contributor

@TomasSlama TomasSlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks for the contribution, I left one more small comment about changeset, but other than that I don't see any problem 🙇 💪

@rasitozcan rasitozcan self-assigned this Jan 4, 2024
@rasitozcan
Copy link
Contributor

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@53.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-2a295f988.30+2a295f988
yarn add @toptal/picasso@42.2.5-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-2a295f988.3+2a295f988
yarn add @toptal/picasso-charts@56.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-2a295f988.30+2a295f988
yarn add @toptal/picasso-codemod@5.6.4-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-2a295f988.80+2a295f988
yarn add @toptal/picasso-forms@66.1.2-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-2a295f988.25+2a295f988
yarn add @toptal/picasso-pictograms@2.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-2a295f988.150+2a295f988
yarn add @toptal/picasso-provider@3.4.3-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-2a295f988.22+2a295f988
yarn add @toptal/picasso-query-builder@1.2.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-2a295f988.18+2a295f988
yarn add @toptal/picasso-rich-text-editor@10.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-2a295f988.30+2a295f988
yarn add @toptal/picasso-shared@13.1.3-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-2a295f988.3+2a295f988
yarn add @toptal/picasso-tailwind@1.0.2-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-2a295f988.10+2a295f988

Copy link
Contributor

@toptalwadiibasmi toptalwadiibasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.

@rasitozcan
Copy link
Contributor

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@53.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-20c8adb09.31+20c8adb09
yarn add @toptal/picasso@42.2.5-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-20c8adb09.4+20c8adb09
yarn add @toptal/picasso-charts@56.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-20c8adb09.31+20c8adb09
yarn add @toptal/picasso-codemod@5.6.4-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-20c8adb09.81+20c8adb09
yarn add @toptal/picasso-forms@66.1.2-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-20c8adb09.26+20c8adb09
yarn add @toptal/picasso-pictograms@2.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-20c8adb09.151+20c8adb09
yarn add @toptal/picasso-provider@3.4.3-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-20c8adb09.23+20c8adb09
yarn add @toptal/picasso-query-builder@1.2.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-20c8adb09.19+20c8adb09
yarn add @toptal/picasso-rich-text-editor@10.0.1-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-20c8adb09.31+20c8adb09
yarn add @toptal/picasso-shared@13.1.3-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-20c8adb09.4+20c8adb09
yarn add @toptal/picasso-tailwind@1.0.2-alpha-cpt-1478-add-clear-feature-to-select-search-in-picasso-20c8adb09.11+20c8adb09

@rasitozcan rasitozcan force-pushed the cpt-1478-add-clear-feature-to-select-search-in-picasso branch from 20c8adb to 0fdf3a6 Compare January 4, 2024 13:25
Copy link

@mkasperowicz mkasperowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, everything works as expected

@angelinastavniiciuc angelinastavniiciuc force-pushed the cpt-1478-add-clear-feature-to-select-search-in-picasso branch from 2cf855f to 410a2c8 Compare January 8, 2024 06:55
@rasitozcan rasitozcan merged commit 2d0c9d4 into master Jan 8, 2024
18 checks passed
@rasitozcan rasitozcan deleted the cpt-1478-add-clear-feature-to-select-search-in-picasso branch January 8, 2024 07:13
@toptal-build toptal-build mentioned this pull request Jan 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution DO NOT ADD MANUALLY Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants