-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Node v20 #4632
base: master
Are you sure you want to change the base?
Upgrade to Node v20 #4632
Conversation
|
9e6c0e8
to
4e34354
Compare
env: | ||
SLACK_BOT_TOKEN: ${{ env.SLACK_BOT_TOKEN }} | ||
|
||
- name: Send a Slack notification on success PR merge | ||
if: ${{ success() && steps.changesets.outputs.published != 'true'}} | ||
uses: slackapi/[email protected] | ||
with: | ||
channel-id: "-frontend-exp-team-notifications" | ||
slack-message: "A new PR was merged to Picasso :parrotspin:" | ||
channel-id: '-frontend-exp-team-notifications' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to change it to something like #-frontend-notifications
@toptal-bot run all |
4e34354
to
9c44a5d
Compare
[FX-NNNN]
Description
Describe the changes and motivations for the pull request.
How to test
Screenshots
Development checks
picasso-tailwind-merge
requires major update (check itsREADME.md
)props
in component with documentationexamples
for componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?