Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid hard-failure #243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Avoid hard-failure #243

wants to merge 2 commits into from

Conversation

katdom13
Copy link

@katdom13 katdom13 commented Jan 23, 2024 •
edited
Loading

Description

This fix reverts the change to the default_html argument and converts it to none if it's not a string

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

@katdom13 katdom13 force-pushed the fix/return-empty-string branch from a471449 to befce00 Compare January 23, 2024 07:34
@katdom13 katdom13 force-pushed the fix/return-empty-string branch from befce00 to c953f00 Compare January 23, 2024 08:05
@katdom13 katdom13 force-pushed the fix/return-empty-string branch from f3c391d to 26e9bfe Compare January 23, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxbridge alxbridge Awaiting requested review from alxbridge

@bcdickinson bcdickinson Awaiting requested review from bcdickinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@katdom13