Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noetic support #58

Draft
wants to merge 82 commits into
base: indigo-devel
Choose a base branch
from
Draft

Noetic support #58

wants to merge 82 commits into from

Conversation

sktometometo
Copy link

@sktometometo sktometometo commented Mar 2, 2022 •
edited
Loading

  • Add noetic support
  • Update myCobot sections
  • Fix some blocks

@sktometometo
Fix sphinx if-else
553af65
@sktometometo
make khi_duaro to apt installation
2e55c09
@sktometometo
add notice for noetic
31cb999
@sktometometo
update circleci for noetic
0a19095
@sktometometo
fix bugs
9b23824
@sktometometo
Disable Nextage Simulator launch for noetic
85bf317
@sktometometo
Enable myCobot simulator section for noetic
1c35334
@sktometometo
update planning image for noetic
3f21bd3
@sktometometo
update インストールの最後に section
d163c5f
@sktometometo
Fix circle build commands for noetic
64f7a73
@sktometometo
Fix typo in index.md
f3e8f1b
@sktometometo
fix typoe and add ref for robot-simulator.md
173908f
@sktometometo
add interactive python example for mycobot
8521d4e
@sktometometo
Revert "Fix circle build commands for noetic"
be59372 
This reverts commit 64f7a73.
@sktometometo
[.circleci] add build command for noetic build
b8f5cee
@sktometometo
[.circleci] add buile-essential installation for build_python3 command
01e125c
@sktometometo
update demo scripts for myCobot
a038d64
@sktometometo
update interactive shell section for mycobot
b63c35f
@sktometometo
update python basic section for mycobot and noetic
afb80a8
@sktometometo
Enable python interactive shell section of mycobot for melodic
8466f42
sktometometo and others added 25 commits October 17, 2022 16:00
@sktometometo
Set auto_start to False for action server of mycobot_interface.py
bcf2702
@kochigami @sktometometo
modify clone package for myCobot: mycobot_ros -> tork_moveit_tutorial
824a5a5
@kochigami @sktometometo
remove explanation about simulator myCobot 320 because we don't clone…
98bcf39 
… mycobot_ros
@kochigami @sktometometo
add explanation about how to start tutorial using real myCobot
7e4d723
@kochigami @sktometometo
add explanation how to setup a real myCobot
ae446cc
@kochigami @sktometometo
set condition (ROS: melodic or noetic) to moveit-tutorial_ja_how-to-u…
187c1f8 
…se-real-mycobot.md
@kochigami @sktometometo
[doc/index.md] update index.md: add moveit-tutorial_ja_how-to-use-rea…
384a163 
…l-mycobot.md to contents
@kochigami @sktometometo
[doc/moveit-tutorial_ja_robot-python_basic.md] modify contents of myc…
88eec74 
…obot_moveit_tutorial_poses.py
@kochigami @sktometometo
[doc/moveit-tutorial_ja_robot-python_basic.md] add myCobot images
52f041d
@sktometometo
fix table
eab0978
@sktometometo
try to fix table
eaa3893
@sktometometo
try to fix table
3f81ea0
@sktometometo
try to fix table
be02f74
@sktometometo
try to fix table
4808880
@sktometometo
try to fix table
3bc03f6
@sktometometo
try to fix table
db557c6
@sktometometo
try to fix table
86fcd8e
@sktometometo
try to fix table
050259b
@sktometometo
try to fix table
f452a09
@sktometometo
try to fix table
67de2e9
@sktometometo
try to fix table
5a97fb3
@kochigami @sktometometo
[doc/moveit-tutorial_ja_robot-python_basic.md] add correct link to an…
1e9f18b 
…other chapter
@kochigami @sktometometo
[doc] update mycobot figures (real robot -> simulator) to make it eas…
5fca45e 
…ier to see
@kochigami @sktometometo
add real robot figures
16b056b
@kochigami @sktometometo
update figs because of wrong poses
466e975
@sktometometo sktometometo mentioned this pull request Nov 18, 2022
Merged
@y-yosuke y-yosuke mentioned this pull request Apr 19, 2023
Open
@y-yosuke
Copy link
Member

すみません，PR の内容に全然追いついていないのですが質問させてください．

myCobot 関係で config や launch， urdf フォルダが追加されていると思いますが， https://github.com/elephantrobotics/mycobot_ros を利用するのではなくてこの tork-a/tork_moveit_tutorial 内に置いておく理由を教えてくれるとありがたいです．

@sktometometo
Copy link
Author

具体的な部分は確認する必要があるのでちょっとお待ちいただきたいのですが、PRの作成時点で https://github.com/elephantrobotics/mycobot_ros は不具合があったため、修正が必要でした。
JSKでは jsk-ros-pkg/jsk_robot#1421 の https://github.com/tongtybj/jsk_robot/blob/7e3196f0d2d2928fb00f38ff5999f4d7bdf46a45/jsk_mycobot_robot/mycobot.rosinstall#L5-L12 に記述のあるように、適切に動作するようにforkした elephantrobotics/mycobot_ros#48 を使ってお、ここからコピーし再構成する形で tork_moveit_tutorial においてあります。
現在の mycobot_ros では適切に動作するかもしれません。

@y-yosuke
Copy link
Member

ありがとうございます． @sktometometo
おおよその経緯が分かりました．助かります．
elephantrobotics/mycobot_ros#48 が merge されるか今後注視したいと思います．

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sktometometo @y-yosuke @kochigami