Add Oracle ODBC Driver #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to 1 task:
|
anotherminh
previously approved these changes
Jan 22, 2025
hblackmer
reviewed
Jan 22, 2025
src/database.ts
Outdated
| @@ -31,6 +32,7 @@ export const SQLDriverWithDataMapping = makeEnum({ | |||
| [DatabaseIntegration.maria]: 'MariaDB', | |||
| [DatabaseIntegration.databrickslakehouse]: 'Databricks Lakehouse', | |||
| [DatabaseIntegration.ibmdb2]: 'IBM DB2', | |||
| [DatabaseIntegration.oracle]: 'Oracle', | |||
There was a problem hiding this comment.
Should we maybe call it Oracle DB to keep it consistent to Contentful and the integration name?
anotherminh
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Links https://transcend.height.app/T-25011
Added new DatabaseIntegration for Oracle