Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oracle ODBC Driver #210

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Add Oracle ODBC Driver #210

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15b35c7
Add Oracle ODBC Driver
Jan 22, 2025
71437e1
fix precommit
Jan 22, 2025
17d52af
update name
Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/database.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export const DatabaseIntegration = makeEnum({
amazons3: 'amazons3',
databrickslakehouse: 'databrickslakehouse',
ibmdb2: 'ibmdb2',
oracle: 'oracle',
});

/**
Expand All @@ -31,6 +32,7 @@ export const SQLDriverWithDataMapping = makeEnum({
[DatabaseIntegration.maria]: 'MariaDB',
[DatabaseIntegration.databrickslakehouse]: 'Databricks Lakehouse',
[DatabaseIntegration.ibmdb2]: 'IBM DB2',
[DatabaseIntegration.oracle]: 'Oracle',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe call it Oracle DB to keep it consistent to Contentful and the integration name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

});

/** Overrides type */
Expand Down
Loading