B 19996 int #12913
Merged
B 19996 int #12913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
antgmann
added
Scrummy Bears
r-mettler
approved these changes
Jun 3, 2024
|
See -Standalone for before and after approvals. |
r-mettler
approved these changes
Jun 3, 2024
antgmann
approved these changes
Jun 4, 2024
MInthavongsay
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-19996
Summary
This task updates the TOO role to show when a domestic crating service item is Standalone in the UI. When a standalone shipment is up for approval, it will be displayed with a '- Standalone' tag on it to alert the TOO.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Setup: Run db_dev_fresh to ensure db changes are in place
Note: When testing I found that many of the service items for existing data are not complete, and will cause the creation of a payment request to error out. To test a payment request with multiple service items it is easiest to just create them yourself.
Access the Office app
Login to the Prime Sim
Add a domestic crating service item with the standalone box checked.
Login as a TOO
Find the Move you edited in the Prime Sim
Note that the newly created service item show '- Standalone' next to the name
Approve the newly created Service Item
Verify it shows ' - Standalone' after the service item has been approved
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots