Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-19728-INT customer upload additional docs #12939

Merged
merged 17 commits into from
Jun 12, 2024

Conversation

paulstonebraker
Copy link
Contributor

@paulstonebraker paulstonebraker commented Jun 4, 2024

Agility ticket

FF Repo PR

Summary

Give the customers the ability to upload documents without affecting their workflow!

This work create a new button for customers that appears on their MoveHome page after a move is submitted, that allows them to provide additional documentation to the government without affecting their workflow. We added a new column to the moves table that houses additional_documents_id. Customer have the ability to upload documents and delete documents after they've been uploaded.

How to test

  1. Login as a customer with a move that has been submitted, and navigate to the MoveHome page of a move.
  2. Click on the Upload Additional Documents button attached to the Profile step.
  3. Confirm the page looks good and the upload/delete works, and persists as you navigate away/log out
  4. Create new moves and add documents to new moves and previous moves, and make sure they're attaching to the correct move
  5. Try and break it

@robot-mymove
Copy link

robot-mymove commented Jun 5, 2024

Warnings
⚠️

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?

View the frontend file org ADR for more information

Generated by 🚫 dangerJS against 5ca6acf

@paulstonebraker paulstonebraker marked this pull request as ready for review June 5, 2024 12:40
@paulstonebraker paulstonebraker requested a review from a team as a code owner June 5, 2024 12:40
@paulstonebraker paulstonebraker added G-Unit Scrum Team G INTEGRATION Slated for Integration Testing labels Jun 5, 2024
@paulstonebraker paulstonebraker changed the title B 19728 2 int B-19728-INT customer upload additional docs Jun 5, 2024
Copy link
Contributor

@loganwc loganwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did what I could not 🙌

@pambecker
Copy link
Contributor

Shouldn't there be a checkin for the FF in the milmove-feature-flags repository also? or was that already done?

@paulstonebraker
Copy link
Contributor Author

paulstonebraker commented Jun 7, 2024

Reviews on pause while I address bug

@@ -133,6 +133,9 @@ export FEATURE_FLAG_MOVE_LOCK=false
export FEATURE_FLAG_OKTA_DODID_INPUT=false
export FEATURE_FLAG_SAFETY_MOVE=true

# Feature flag for additional supporting documents uploaded by customer
export FEATURE_FLAG_MANAGE_SUPPORTING_DOCS=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this FF in the feature flag repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Pam reminded me on Friday but I forgot amidst bug fix found during her review. Will push to ff repo shortly

return handlers.ResponseForError(appCtx.Logger(), e), e
}

if e != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is duplicate from the if statement above, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep good eye! Removed

@paulstonebraker paulstonebraker merged commit 9284009 into integrationTesting Jun 12, 2024
30 checks passed
@paulstonebraker paulstonebraker deleted the B-19728-2-INT branch June 12, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
G-Unit Scrum Team G INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

5 participants