-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B-19728-INT customer upload additional docs #12939
Conversation
…naldocuments isn't complete
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did what I could not 🙌
Shouldn't there be a checkin for the FF in the milmove-feature-flags repository also? or was that already done? |
Reviews on pause while I address bug |
9116e08
to
c9ea504
Compare
@@ -133,6 +133,9 @@ export FEATURE_FLAG_MOVE_LOCK=false | |||
export FEATURE_FLAG_OKTA_DODID_INPUT=false | |||
export FEATURE_FLAG_SAFETY_MOVE=true | |||
|
|||
# Feature flag for additional supporting documents uploaded by customer | |||
export FEATURE_FLAG_MANAGE_SUPPORTING_DOCS=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this FF in the feature flag repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Pam reminded me on Friday but I forgot amidst bug fix found during her review. Will push to ff repo shortly
pkg/handlers/internalapi/uploads.go
Outdated
return handlers.ResponseForError(appCtx.Logger(), e), e | ||
} | ||
|
||
if e != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is duplicate from the if statement above, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep good eye! Removed
Agility ticket
FF Repo PR
Summary
Give the customers the ability to upload documents without affecting their workflow!
This work create a new button for customers that appears on their MoveHome page after a move is submitted, that allows them to provide additional documentation to the government without affecting their workflow. We added a new column to the moves table that houses additional_documents_id. Customer have the ability to upload documents and delete documents after they've been uploaded.
How to test