Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-19728-INT customer upload additional docs #12939

Merged
merged 17 commits into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from 36 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -872,6 +872,7 @@ commands:
export FEATURE_FLAG_MOVE_LOCK=false
export FEATURE_FLAG_OKTA_DODID_INPUT=false
export FEATURE_FLAG_SAFETY_MOVE=false
export FEATURE_FLAG_MANAGE_SUPPORTING_DOCS=false

# disable for speed, playwright tests can fail otherwise
export DB_DEBUG=false
Expand Down Expand Up @@ -906,6 +907,7 @@ commands:
FEATURE_FLAG_MOVE_LOCK: 'false'
FEATURE_FLAG_OKTA_DODID_INPUT: 'false'
FEATURE_FLAG_SAFETY_MOVE: 'false'
FEATURE_FLAG_MANAGE_SUPPORTING_DOCS: 'false'
command: |
SHARD=$((${CIRCLE_NODE_INDEX}+1))
PLAYWRIGHT_JUNIT_OUTPUT_NAME=playwright-results.xml \
Expand Down
3 changes: 3 additions & 0 deletions .envrc
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ export FEATURE_FLAG_MOVE_LOCK=false
export FEATURE_FLAG_OKTA_DODID_INPUT=false
export FEATURE_FLAG_SAFETY_MOVE=true

# Feature flag for additional supporting documents uploaded by customer
export FEATURE_FLAG_MANAGE_SUPPORTING_DOCS=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this FF in the feature flag repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Pam reminded me on Friday but I forgot amidst bug fix found during her review. Will push to ff repo shortly


# Feature flags to disable certain shipment types
export FEATURE_FLAG_PPM=true
export FEATURE_FLAG_NTS=true
Expand Down
1 change: 1 addition & 0 deletions config/env/demo.app-client-tls.env
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,4 @@ FEATURE_FLAG_COAST_GUARD_EMPLID=false
FEATURE_FLAG_MOVE_LOCK=false
FEATURE_FLAG_OKTA_DODID_INPUT=false
FEATURE_FLAG_SAFETY_MOVE=false
FEATURE_FLAG_MANAGE_SUPPORTING_DOCS=false
1 change: 1 addition & 0 deletions config/env/demo.app.env
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,4 @@ FEATURE_FLAG_COAST_GUARD_EMPLID=false
FEATURE_FLAG_MOVE_LOCK=false
FEATURE_FLAG_OKTA_DODID_INPUT=false
FEATURE_FLAG_SAFETY_MOVE=false
FEATURE_FLAG_MANAGE_SUPPORTING_DOCS=false
1 change: 1 addition & 0 deletions config/env/exp.app-client-tls.env
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,4 @@ FEATURE_FLAG_COAST_GUARD_EMPLID=false
FEATURE_FLAG_MOVE_LOCK=false
FEATURE_FLAG_OKTA_DODID_INPUT=false
FEATURE_FLAG_SAFETY_MOVE=false
FEATURE_FLAG_MANAGE_SUPPORTING_DOCS=false
1 change: 1 addition & 0 deletions config/env/exp.app.env
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,4 @@ FEATURE_FLAG_COAST_GUARD_EMPLID=false
FEATURE_FLAG_MOVE_LOCK=false
FEATURE_FLAG_OKTA_DODID_INPUT=false
FEATURE_FLAG_SAFETY_MOVE=false
FEATURE_FLAG_MANAGE_SUPPORTING_DOCS=false
1 change: 1 addition & 0 deletions config/env/loadtest.app-client-tls.env
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,4 @@ FEATURE_FLAG_COAST_GUARD_EMPLID=false
FEATURE_FLAG_MOVE_LOCK=false
FEATURE_FLAG_OKTA_DODID_INPUT=false
FEATURE_FLAG_SAFETY_MOVE=false
FEATURE_FLAG_MANAGE_SUPPORTING_DOCS=false
1 change: 1 addition & 0 deletions config/env/loadtest.app.env
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,4 @@ FEATURE_FLAG_COAST_GUARD_EMPLID=false
FEATURE_FLAG_MOVE_LOCK=false
FEATURE_FLAG_OKTA_DODID_INPUT=false
FEATURE_FLAG_SAFETY_MOVE=false
FEATURE_FLAG_MANAGE_SUPPORTING_DOCS=false
1 change: 1 addition & 0 deletions config/env/prd.app-client-tls.env
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,4 @@ FEATURE_FLAG_COAST_GUARD_EMPLID=false
FEATURE_FLAG_MOVE_LOCK=false
FEATURE_FLAG_OKTA_DODID_INPUT=false
FEATURE_FLAG_SAFETY_MOVE=false
FEATURE_FLAG_MANAGE_SUPPORTING_DOCS=false
1 change: 1 addition & 0 deletions config/env/prd.app.env
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,4 @@ FEATURE_FLAG_COAST_GUARD_EMPLID=false
FEATURE_FLAG_MOVE_LOCK=false
FEATURE_FLAG_OKTA_DODID_INPUT=false
FEATURE_FLAG_SAFETY_MOVE=false
FEATURE_FLAG_MANAGE_SUPPORTING_DOCS=false
1 change: 1 addition & 0 deletions config/env/stg.app-client-tls.env
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,4 @@ FEATURE_FLAG_COAST_GUARD_EMPLID=false
FEATURE_FLAG_MOVE_LOCK=false
FEATURE_FLAG_OKTA_DODID_INPUT=false
FEATURE_FLAG_SAFETY_MOVE=false
FEATURE_FLAG_MANAGE_SUPPORTING_DOCS=false
1 change: 1 addition & 0 deletions config/env/stg.app.env
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,4 @@ FEATURE_FLAG_COAST_GUARD_EMPLID=false
FEATURE_FLAG_MOVE_LOCK=false
FEATURE_FLAG_OKTA_DODID_INPUT=false
FEATURE_FLAG_SAFETY_MOVE=false
FEATURE_FLAG_MANAGE_SUPPORTING_DOCS=false
8 changes: 8 additions & 0 deletions config/flipt/storage/development.features.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,14 @@ flags:
- segment:
key: mil-app
value: true
- key: manage_supporting_docs
name: Additional doc upload feature flag
type: BOOLEAN_FLAG_TYPE
enabled: false
rollouts:
- segment:
key: mil-app
value: false
- key: boolean_flag
name: Boolean Flag
type: BOOLEAN_FLAG_TYPE
Expand Down
1 change: 1 addition & 0 deletions migrations/app/migrations_manifest.txt
Original file line number Diff line number Diff line change
Expand Up @@ -943,6 +943,7 @@
20240521184834_add_standalone_field_to_service_items.up.sql
20240522124339_add_csr_to_roles.up.sql
20240524214247_add_sit_location_moving_expenses.up.sql
20240529181303_add_additional_documents_id_col_to_moves.up.sql
20240530020648_adding_standalone_crate_service_param.up.sql
20240530084720_rename_qae_csr_to_just_qae.up.sql
20240531050324_adding_standalone_crate_cap.up.sql
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
ALTER TABLE moves ADD COLUMN IF NOT EXISTS additional_documents_id uuid DEFAULT NULL;

COMMENT ON COLUMN moves.additional_documents_id IS 'A foreign key that points to the document table for referencing additional documents';
1 change: 1 addition & 0 deletions pkg/factory/shared.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ type CustomType string
// You can have CustomType like ResidentialAddress to define specifically
// where this address will get created and nested
var Address CustomType = "Address"
var AdditionalDocuments CustomType = "AdditionalDocuments"
var AdminUser CustomType = "AdminUser"
var AuditHistory CustomType = "AuditHistory"
var BackupContact CustomType = "BackupContact"
Expand Down
7 changes: 7 additions & 0 deletions pkg/gen/internalapi/configure_mymove.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ func configureAPI(api *internaloperations.MymoveAPI) http.Handler {
// You may change here the memory limit for this multipart form parser. Below is the default (32 MB).
// uploads.CreateUploadMaxParseMemory = 32 << 20
// You may change here the memory limit for this multipart form parser. Below is the default (32 MB).
// moves.UploadAdditionalDocumentsMaxParseMemory = 32 << 20
// You may change here the memory limit for this multipart form parser. Below is the default (32 MB).
// orders.UploadAmendedOrdersMaxParseMemory = 32 << 20

if api.OfficeApproveMoveHandler == nil {
Expand Down Expand Up @@ -378,6 +380,11 @@ func configureAPI(api *internaloperations.MymoveAPI) http.Handler {
return middleware.NotImplemented("operation ppm.UpdateWeightTicket has not yet been implemented")
})
}
if api.MovesUploadAdditionalDocumentsHandler == nil {
api.MovesUploadAdditionalDocumentsHandler = moves.UploadAdditionalDocumentsHandlerFunc(func(params moves.UploadAdditionalDocumentsParams) middleware.Responder {
return middleware.NotImplemented("operation moves.UploadAdditionalDocuments has not yet been implemented")
})
}
if api.OrdersUploadAmendedOrdersHandler == nil {
api.OrdersUploadAmendedOrdersHandler = orders.UploadAmendedOrdersHandlerFunc(func(params orders.UploadAmendedOrdersParams) middleware.Responder {
return middleware.NotImplemented("operation orders.UploadAmendedOrders has not yet been implemented")
Expand Down
132 changes: 132 additions & 0 deletions pkg/gen/internalapi/embedded_spec.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading