-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add golang 1.19 and update of copyright year #203
base: master
Are you sure you want to change the base?
Conversation
I am asking others maintainers support here, because I don't know why test fail... maybe they should be updated, but I need more context. |
…shellchek to latest 0.8.0
…nv file for go bootsrap
…nv file for go bootsrap
I think that #204 is trying to achieve my same result, at the moment both build are in failed state. Mine at the moment is 2 out of 3. should we collaborate to get it 3 out of 3? Mine fails for some reason I couldn't understand on installing go 1.19.1 with target arm64. It does install it on travis native arch, so the go binary is not executable. But as far as I understood, gimme is expected to try to rebuild go using cross compilers and this way it should then work on this architecture too. But these are just what I got, I may be wrong. I am here again asking for some clarification by the official maintainers of the project. |
Could this also be related to #154? |
@philpennock I tried to use |
The only test that fails on this branch is the installation on ARM64 using cross compilation. I don't know if this has ever worked. I will stop here with developments unless someone else (possibly a travis-ci maintainer), points out to some solution/suggestion/way to go. If someone thinks this should be merged, I would go for a squash merge, since I did many commits to try different stuff. |
One thing that makes me think that this has never worked is that the error is the following:
env file is created and also the go binary is downloaded. The go binary is probably compiled for arm64 architecture and doesn't work on the native amd architecture. |
@Hammond95 Hey, thanks for your contribution. @mustafa-travisci Could you take a look? It seems that you've been working on similar issue. |
@r-arek I haven't received any feedback from @mustafa-travisci. It seems to me that the project has always had cross compilation issues (see #166 #154 #42). We should probably solve these issue on a dedicated PR. |
I don't want to bother anyone here, but I think this PR adds the functionality to download go1.19, so it could be ok to merge it. The cross-compiling functionality as far as I can see, has never worked well, so that problem should be addressed in a different PR. |
@r-arek Is the project dead? It's been more than a month and I didn't receive any feedback :( |
What has changed
patched a bug in the python script fetching go binaries urls:
gimme/fetch-object-urls
Line 22 in 01e9428
This code probably should be improved since the links grow in time.
updated copyright:
gimme/gimme
Line 58 in 01e9428
add go 1.19 to version list:
gimme/gimme
Line 288 in 01e9428
add a better method to compare version numbers in runtests:
gimme/runtests
Line 21 in 01e9428
gimme/runtests
Line 90 in 01e9428
updated shfmt and shellcheck versions:
gimme/.travis.yml
Lines 14 to 15 in 01e9428
expanded matrix in order to test separately failing builds:
gimme/.travis.yml
Lines 23 to 51 in 01e9428
I think this could be a better approach also if we want to test on different architectures and different env variables.
ran
make lint
which performed minor syntax changesran
make update-binary-versions
to update links and versions in files of the test data.