Retry HTTP GET requests if one fails with 5xx errors #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frsyuki
force-pushed
the
retry-on-all-server-errors
branch
from
56e04a4
to
68267ef
Compare
Especially including 504 Gateway Timeout.
frsyuki
force-pushed
the
retry-on-all-server-errors
branch
from
68267ef
to
7e0c122
Compare
|
@miniway could you review this change? I think 504 Gateway Timeout should be retried. But not sure whether all other 5xx errors should be retried or not |
|
looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially including 504 Gateway Timeout.