Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry HTTP GET requests if one fails with 5xx errors #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Retry HTTP GET requests if one fails with 5xx errors #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/presto/client/statement_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,13 @@ def faraday_get_with_retry(uri, &block)
return response.body
end

if response.status != 503 # retry only if 503 Service Unavailable
# deterministic error
if (response.status / 100).to_i != 5
# client error is deterministic error
@exception = PrestoHttpError.new(response.status, "Presto API error at #{uri} returned #{response.status}: #{response.body}")
raise @exception
end

# retry if server-error
end

attempts += 1
Expand Down