WIP injecting component names into activity log #2951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
changed the title
nelsonkopliku
force-pushed
the
inject-component-names-into-activity-log
branch
from
8de8d36
to
8bb40c3
Compare
nelsonkopliku
force-pushed
the
inject-component-names-into-activity-log
branch
from
8bb40c3
to
229db73
Compare
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an exploration about the possibility to enrich Activity log metadata.
The rationale behind is improving human-friendly identification of the resource the activity log entry is related to and improving log searchability.
The thing could be summarized as: adding a human friendly resource name to the activity log metadata when it does not already have one
Alternative to the approach tried in this PR could be upcasting all necessary events to also carry the extra information needed. However this would not be sufficient for non event sourced related activities: ie when tagging/untagging we still need some sort of metadata enrichment process to get the resource name being tagged/untagged.