Expose components retrieval by id #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…registered or not
… registered or not
…is registered or not
nelsonkopliku
added
enhancement
nelsonkopliku
changed the title
This was referenced Sep 19, 2024
gagandeepb
approved these changes
Sep 19, 2024
balanza
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes a
by_idfunction forHosts,Clusters,DatabasesandSapSystemsreturning the required item regardless of whether it is registered or not.These kind of query will be necessary when enriching activity log metadata with a friendlier name of the component/entity.
See #2951
Note: I have considered the alternative of keeping the
Repo.get(...)function calls inside metadata enricher, without exposing them from the different entities' contexts, but it just felt the right thing adding them there. Open for feedback.How was this tested?
Automated tests added.