Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labeling - not able to add label to ERC20, ERC721, ERC1155 and internal transactions #3545

Open
bosomt opened this issue Mar 15, 2021 · 7 comments
Labels
altcoins not related to bitcoin EVM Issues related to networks based on Ethereum Virtual Machine feature Product related issue visible for end user labelling Naming of transactions and accounts

Comments

@bosomt
Copy link
Contributor

bosomt commented Mar 15, 2021

Describe the bug
It's not possible to attach label to Ethereum ERC20 transaction, add label button is missing.

Steps to reproduce:

  1. Load Ethereum wallet that contains ERC20 transactions
  2. Add label to ERC20 transaction
  3. Observe

Info:

  • Suite version: web 21.4.0 (1da73bf)
  • Browser: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Firefox/86.0
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: model T 2.3.5 regular

Expected result:
It is possible to attach label to Ethereum ERC20 transactions

Actual result:
It's not possible to attach label to Ethereum ERC20 transactions

Screenshots:
https://www.youtube.com/watch?v=SuaXtBKajyE

@keo
Copy link

keo commented May 4, 2021

👍

@bosomt
Copy link
Contributor Author

bosomt commented Jul 22, 2021

same behavior in latest version

Info:

  • Suite version: desktop 21.8.0 (566ba34)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/21.8.0 Chrome/89.0.4389.69 Electron/12.0.0 Safari/537.36
  • OS: Linux x86_64
  • Screen: 2560x1440
  • Device: model 1 1.10.1 regular

@hynek-jina hynek-jina added the feature Product related issue visible for end user label Dec 16, 2021
@tsusanka tsusanka added HIGH and removed MEDIUM labels Mar 14, 2022
@hynek-jina hynek-jina removed the HIGH label Jun 8, 2022
@hynek-jina hynek-jina added the altcoins not related to bitcoin label Jul 22, 2022
@tomasklim
Copy link
Member

It applies to all ERC (ERC-20, ERC-721, ERC1155) and internal transfers.

@sime sime moved this from 🤝 Needs QA to 🎯 To do in Suite Desktop Apr 27, 2023
@tomasklim tomasklim changed the title Labeling - not able to add label to ERC20 transaction Labeling - not able to add label to ERC20, ERC721, ERC1155 and internal transactions Jul 21, 2023
@matejkriz
Copy link
Member

let's wait with this until #6304 is done

@tomasklim tomasklim added the EVM Issues related to networks based on Ethereum Virtual Machine label Jan 23, 2024
@dlitz
Copy link

dlitz commented Jul 18, 2024

Would you accept a pull request if someone implemented this sooner?

From an accounting/tax-compliance point-of-view, this omission makes it pretty cumbersome to use trezor-suite, and work on #6304 appears to have stalled.

Looking at the code, I don't see why ENCRYPTION_VERSION=2 (which is a trivial change to how the master key is derived, AFAICT) would make any difference to implementing a fix for this issue.

@Hannsek
Copy link
Contributor

Hannsek commented Jul 19, 2024

Hey, #6304 will be done this month.

@dlitz
Copy link

dlitz commented Jul 20, 2024

Oh, I see there's some discussion on #9130. That's good. FYI, I also just asked a question in that thread about the cryptography, since what I saw while looking at this code seems somewhat concerning, although I may be misunderstanding what's planned here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
altcoins not related to bitcoin EVM Issues related to networks based on Ethereum Virtual Machine feature Product related issue visible for end user labelling Naming of transactions and accounts
Projects
Status: 🎯 To do
Development

No branches or pull requests