Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/group pending transactions by date #12975

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Feat/group pending transactions by date #12975

merged 6 commits into from
Jul 31, 2024

Conversation

komret
Copy link
Contributor

@komret komret commented Jun 19, 2024 •
edited by matejkriz
Loading

Group pending transactions by date. Otherwise, only time is displayed which is confusing when the transaction has been in a pending state for a long time.

Screenshot 2024-06-20 at 17 17 08

image

@komret komret force-pushed the feat/group-pending-transactions-by-date branch 7 times, most recently from 40b14fe to f20b346 Compare June 21, 2024 15:56
@komret komret force-pushed the feat/group-pending-transactions-by-date branch from f20b346 to 3b0cb27 Compare July 22, 2024 13:45
@komret komret marked this pull request as ready for review July 22, 2024 14:25
@komret komret requested a review from a team as a code owner July 22, 2024 14:25
@tomasklim tomasklim mentioned this pull request Jul 29, 2024
Closed
@komret komret force-pushed the feat/group-pending-transactions-by-date branch from 4bd66f5 to 81fc6db Compare July 31, 2024 06:36
@komret
Copy link
Contributor Author

komret commented Jul 31, 2024 •
edited
Loading

We encountered some (unrelated) weird stuff when testing this, but given this is testnet and very edge-casey, I am not going to investigate further.

This behaviour can (for now) be observed on the second default testnet account with tbtc2 backend:

  1. The date and time of pending transactions changes over time. The have been made sometime in May, but the date keeps updating, usually it is the same day or the day before. Looks like a blockbook bug. Reported here: Unstable timestamp for pending transactions blockbook#1118.
    Screenshot 2024-07-31 at 9 53 38

  2. When attempting to bump fee, the modal says the output amount is reduced, but in fact it is increased and the transaction cannot be sing due to Transaction signing error: Increasing original output amounts is not supported. There is some bug in the algorithm, but bear in mind these are chained transactions, sent to myself, possibly to a change address, and there was a fee spike on testnet at the time the original ones were broadcast.
    Screenshot 2024-07-31 at 9 48 31

@komret
Copy link
Contributor Author

komret commented Jul 31, 2024

/rebase

@github-actions GitHub Actions
Copy link

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/10179704384

@komret komret enabled auto-merge (rebase) July 31, 2024 11:56
Lemonexe and others added 6 commits July 31, 2024 11:56
@Lemonexe @komret
feat: group pending transactions by date
81634e3 
refactor groupTransactionsByDate to enable/disable grouping pending

split DayHeader to create PendingHeader

refactor TransactionList: split pending & confirmed, rather than lumping them together

refactor useMemo maps to FCs

rename DayHeader to GroupHeader which more properly reflects its purpose

Revert "REVERT ME: mock data for development"

This reverts commit 5f2cf76.

CR: use arrayPartition

CR: don't use FC

GroupHeaders file reorganization

rename Wrapper to HeaderWrapper

extract TransactionGroupedList

refactor groupTransactionsByDate

monkey-patch original behavior in suite-native

more test cases
@komret
chore: update lockfile
a751229
@komret
fix: handle no-blocktime transaction edge case
b5390ae
@komret
test(suite): mark transaction groups as pending or confirmed
9cfc0a0
@komret
fix(suite-native): add fallback to []
45ad0e3
@matejkriz @komret
fix(suite-native): pending transactions at the beginning of the list …
8c1ec92 
…in one separate group as before
@trezor-ci trezor-ci force-pushed the feat/group-pending-transactions-by-date branch from 5257993 to 8c1ec92 Compare July 31, 2024 11:56
@komret komret merged commit a9d04a5 into develop Jul 31, 2024
84 of 85 checks passed
@komret komret deleted the feat/group-pending-transactions-by-date branch July 31, 2024 12:05
@komret komret mentioned this pull request Jul 31, 2024
Open
@komret komret mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejkriz matejkriz matejkriz left review comments

@peter-sanderson peter-sanderson peter-sanderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@komret @matejkriz @peter-sanderson @Lemonexe