Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(connect): update device authenticity config #13420

Conversation

trezor-ci
Copy link
Contributor

@trezor-ci trezor-ci commented Jul 18, 2024

@trezor/connect check data for device Authenticity

This is an automatically created PR.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@tsusanka tsusanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also checked T3B1 and filed #13422.

@mroz22
Copy link
Contributor

mroz22 commented Jul 19, 2024

@karliatto are we missing some types?

@karliatto
Copy link
Member

@karliatto are we missing some types?

Yes, this PR is first time in the repository that we add something about T3B1 so it is missing it in types.

@mroz22 mroz22 force-pushed the chore/update-device-authenticity-config-2406fe1ef0348b1bb7338d1fca67203601f0770f branch from 4e1f930 to 6a61f4c Compare July 19, 2024 15:09
@mroz22
Copy link
Contributor

mroz22 commented Jul 19, 2024

sry, I forced pushed here something I thought was a nitpick but it turned into something bigger #13439. so @karliatto if we don't close this, another PR with the same content will be created, right? It would be nice to change bots behavior maybe not to do it if previous PR exists?

@mroz22 mroz22 closed this Jul 19, 2024
@mroz22 mroz22 deleted the chore/update-device-authenticity-config-2406fe1ef0348b1bb7338d1fca67203601f0770f branch July 19, 2024 16:27
@karliatto
Copy link
Member

sry, I forced pushed here something I thought was a nitpick but it turned into something bigger #13439. so @karliatto if we don't close this, another PR with the same content will be created, right? It would be nice to change bots behavior maybe not to do it if previous PR exists?

Yes, I can make it so if the changes are the same it will not create new branch and PR. That will solve the issue that if the PR is not merged the same day it will create new one. 👍

@mroz22
Copy link
Contributor

mroz22 commented Jul 22, 2024

it would be nice, not a very high priority however. but I guess all those automated "update something" PR should have this mechanism

@karliatto
Copy link
Member

it would be nice, not a very high priority however. but I guess all those automated "update something" PR should have this mechanism

The issue creating PR when there is already one open should be solved by this #13455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants