-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(connect): update device authenticity config #13420
chore(connect): update device authenticity config #13420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also checked T3B1 and filed #13422.
@karliatto are we missing some types? |
Yes, this PR is first time in the repository that we add something about |
4e1f930
to
6a61f4c
Compare
sry, I forced pushed here something I thought was a nitpick but it turned into something bigger #13439. so @karliatto if we don't close this, another PR with the same content will be created, right? It would be nice to change bots behavior maybe not to do it if previous PR exists? |
Yes, I can make it so if the changes are the same it will not create new branch and PR. That will solve the issue that if the PR is not merged the same day it will create new one. 👍 |
it would be nice, not a very high priority however. but I guess all those automated "update something" PR should have this mechanism |
The issue creating PR when there is already one open should be solved by this #13455 |
@trezor/connect check data for device Authenticity
This is an automatically created PR.