Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(script): check authenticity data branch name based on content #13455

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

karliatto
Copy link
Member

Description

Use the content of the changes instead of the commit hash to create new branch with changes. If we use the commit hash it will always different since it is not based only on the content. This way if there is a PR open with same changes the script will fail when pushing the new branch (because it already exists and it not -force) and it will not create new PR everyday we do not merge the PR.

Related Issue

Related to #13420 (comment)

Copy link
Contributor

@mroz22 mroz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@karliatto karliatto merged commit e8a0c9a into develop Jul 30, 2024
24 checks passed
@karliatto karliatto deleted the ci/make-keys-check-not-create-new-pr branch July 30, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants