Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite): show just receiving network in add account #16023

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

TomasBoda
Copy link
Contributor

Description

When buying a coin and creating a new account for that coin, the coin select modal should show only the coin we want to buy and hide all other irrelevant coins.

Moreover, when buying a coin that is not supported by Suite, disable creating a new account for that coin.

Related Issue

Resolve #14847

Screenshots:

We are buying Cardano and creating a new account for Cardano, therefore the modal only shows Cardano.

add-account-modal

We are buying Arbitrum, which is not supported in Suite, therefore there is only the option to use an account that is not in Suite.

disabled-new-account

@TomasBoda TomasBoda self-assigned this Dec 18, 2024
@TomasBoda TomasBoda changed the title Add account show just receiving network feat(suite): show just receiving network in add account Dec 18, 2024
adderpositive

This comment was marked as resolved.

@@ -129,7 +130,9 @@ const useCoinmarketVerifyAccount = ({
);

const { supportedMainnets, supportedTestnets } = useNetworkSupport();
const findNetworkByType = (network: Network) => network.networkType === currency;
const currencyNetwork = currency === undefined ? undefined : cryptoIdToNetwork(currency);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick

Suggested change
const currencyNetwork = currency === undefined ? undefined : cryptoIdToNetwork(currency);
const currencyNetwork = currency && cryptoIdToNetwork(currency);

@adderpositive
Copy link
Contributor

Good job @TomasBoda. Looks good.

@TomasBoda TomasBoda force-pushed the add-account-show-just-receiving-network branch from d49bf6d to b0b8faf Compare December 19, 2024 13:31
Copy link
Member

@tomasklim tomasklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please better organise commits + there is one more bug (when non-debug)

When you have network enabled and your previous account is empty

Screen.Recording.2024-12-27.at.13.36.13.mov

It should look like this
Screenshot 2024-12-27 at 13 37 47

@TomasBoda TomasBoda force-pushed the add-account-show-just-receiving-network branch 10 times, most recently from f4a0ebc to c4f0e77 Compare January 3, 2025 09:33
@TomasBoda TomasBoda force-pushed the add-account-show-just-receiving-network branch from c4f0e77 to ff1329a Compare January 3, 2025 12:03
@TomasBoda TomasBoda force-pushed the add-account-show-just-receiving-network branch from 1750c64 to 43e1633 Compare January 3, 2025 12:13
@tomasklim tomasklim merged commit b6de9c9 into develop Jan 3, 2025
29 of 31 checks passed
@tomasklim tomasklim deleted the add-account-show-just-receiving-network branch January 3, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trading - add account - show just the receiving network
4 participants