-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(suite): show just receiving network in add account #16023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasBoda
commented
Dec 18, 2024
.../src/components/suite/modals/ReduxModal/UserContextModal/AddAccountModal/AddAccountModal.tsx
Outdated
Show resolved
Hide resolved
TomasBoda
commented
Dec 18, 2024
.../src/components/suite/modals/ReduxModal/UserContextModal/AddAccountModal/AddAccountModal.tsx
Outdated
Show resolved
Hide resolved
TomasBoda
commented
Dec 18, 2024
packages/suite/src/hooks/wallet/coinmarket/form/useCoinmarketVerifyAccount.tsx
Outdated
Show resolved
Hide resolved
TomasBoda
commented
Dec 18, 2024
packages/suite/src/hooks/wallet/coinmarket/form/useCoinmarketVerifyAccount.tsx
Outdated
Show resolved
Hide resolved
TomasBoda
commented
Dec 18, 2024
.../src/components/suite/modals/ReduxModal/UserContextModal/AddAccountModal/AddAccountModal.tsx
Outdated
Show resolved
Hide resolved
TomasBoda
changed the title
Add account show just receiving network
feat(suite): show just receiving network in add account
Dec 18, 2024
adderpositive
approved these changes
Dec 19, 2024
@@ -129,7 +130,9 @@ const useCoinmarketVerifyAccount = ({ | |||
); | |||
|
|||
const { supportedMainnets, supportedTestnets } = useNetworkSupport(); | |||
const findNetworkByType = (network: Network) => network.networkType === currency; | |||
const currencyNetwork = currency === undefined ? undefined : cryptoIdToNetwork(currency); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick
Suggested change
const currencyNetwork = currency === undefined ? undefined : cryptoIdToNetwork(currency); | |
const currencyNetwork = currency && cryptoIdToNetwork(currency); |
packages/suite/src/hooks/wallet/coinmarket/form/useCoinmarketVerifyAccount.tsx
Outdated
Show resolved
Hide resolved
Good job @TomasBoda. Looks good. |
TomasBoda
force-pushed
the
add-account-show-just-receiving-network
branch
from
December 19, 2024 13:31
d49bf6d
to
b0b8faf
Compare
enjojoy
reviewed
Dec 20, 2024
.../src/components/suite/modals/ReduxModal/UserContextModal/AddAccountModal/AddAccountModal.tsx
Outdated
Show resolved
Hide resolved
.../src/components/suite/modals/ReduxModal/UserContextModal/AddAccountModal/AddAccountModal.tsx
Outdated
Show resolved
Hide resolved
.../src/components/suite/modals/ReduxModal/UserContextModal/AddAccountModal/AddAccountModal.tsx
Outdated
Show resolved
Hide resolved
.../src/components/suite/modals/ReduxModal/UserContextModal/AddAccountModal/AddAccountModal.tsx
Outdated
Show resolved
Hide resolved
tomasklim
requested changes
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TomasBoda
force-pushed
the
add-account-show-just-receiving-network
branch
10 times, most recently
from
January 3, 2025 09:33
f4a0ebc
to
c4f0e77
Compare
TomasBoda
force-pushed
the
add-account-show-just-receiving-network
branch
from
January 3, 2025 12:03
c4f0e77
to
ff1329a
Compare
TomasBoda
force-pushed
the
add-account-show-just-receiving-network
branch
from
January 3, 2025 12:13
1750c64
to
43e1633
Compare
tomasklim
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When buying a coin and creating a new account for that coin, the coin select modal should show only the coin we want to buy and hide all other irrelevant coins.
Moreover, when buying a coin that is not supported by Suite, disable creating a new account for that coin.
Related Issue
Resolve #14847
Screenshots:
We are buying Cardano and creating a new account for Cardano, therefore the modal only shows Cardano.
We are buying Arbitrum, which is not supported in Suite, therefore there is only the option to use an account that is not in Suite.