Add support for passing header X-Trino-Client-Tags #309

laserninja · 2025-07-17T00:00:36Z

Add support for X-Trino-Client-Tags header

Description

This PR adds support for the X-Trino-Client-Tags header in the Grafana Trino datasource plugin. The X-Trino-Client-Tags header is part of the official Trino client protocol and allows sending a comma-separated list of tag strings to identify Trino resource groups, which is useful for resource management and query monitoring.

How to Use

Navigate to the Trino datasource configuration page in Grafana
In the "Trino" section, find the "Client tags" field
Enter a comma-separated list of tags (e.g., grafana,dashboard,analytics)
Save the configuration

The tags will be automatically sent with every query to help Trino administrators identify and manage resource usage from different client sources.

Technical Details

The X-Trino-Client-Tags header is only sent when client tags are configured (optional field)
Tags are stored as a comma-separated string in the datasource configuration
No breaking changes - existing configurations will continue to work unchanged

Testing

Go backend builds successfully
Frontend TypeScript compiles without errors
All existing functionality remains intact
New feature is optional and doesn't affect existing setups

References

cla-bot · 2025-07-17T00:00:39Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

harksin · 2025-08-12T09:21:21Z

Realy usefull ! is it planned to release this soon ?

jaleed-sudo · 2025-08-20T07:32:00Z

Good job !
I also need this PR
Do you have a release date for this PR ?

src/ConfigEditor.tsx

RotRotAl · 2025-09-18T14:19:22Z

src/e2e.test.ts

 async function setupDataSourceWithAccessToken(page: Page) {
    await page.getByTestId('data-testid Datasource HTTP settings url').fill('http://trino:8080');
-    await page.locator('div').filter({hasText: /^Impersonate logged in userAccess token$/}).getByLabel('Toggle switch').click();
+    await page.locator('#trino-settings-enable-impersonation').click({ force: true });


Why is it in the same pr? is it related to the client tags?

The CI tests were failing so I just fixed it here. Should I revert it?

In my opinion it should be a separated pr, taging a contributor that had merged pr recently. @nineinchnick

How do I fix the failing unit tests then?

yes, @nineinchnick let me know if I should create a new MR for this minor fix

That would be ideal, but also see #303 where I'm trying to refactor tests to run on the latest and newest supported Grafana versions. This is required for publishing a new release, but I'm blocked there since I don't know Playwright.

#318
I also don't know Playwright. I can take a look using Copilot if there is no one else to take a look.

So what are we doing? Can i help it get merged?

This test is not failing on the main branch. Can you remove this change from this PR if there's another one open that fixes it?

README.md

RoeyoOgen · 2025-09-21T05:43:05Z

@laserninja pls address

README.md

RotRotAl · 2025-09-21T08:13:24Z

src/e2e.test.ts

 async function setupDataSourceWithAccessToken(page: Page) {
    await page.getByTestId('data-testid Datasource HTTP settings url').fill('http://trino:8080');
-    await page.locator('div').filter({hasText: /^Impersonate logged in userAccess token$/}).getByLabel('Toggle switch').click();
+    await page.locator('#trino-settings-enable-impersonation').click({ force: true });


In my opinion it should be a separated pr, taging a contributor that had merged pr recently. @nineinchnick

RotRotAl · 2025-10-18T06:52:30Z

Hi what’s going on? Can i help it get merged? @nineinchnick @laserninja

RotRotAl · 2025-10-21T15:25:23Z

@RoeyoOgen may you help with getting it merged?

laserninja · 2025-10-25T17:02:26Z

@RotRotAl can you check this? trying to get it working without "force"
#318

src/ConfigEditor.tsx

nineinchnick · 2025-10-28T15:30:13Z

src/e2e.test.ts

 async function setupDataSourceWithAccessToken(page: Page) {
    await page.getByTestId('data-testid Datasource HTTP settings url').fill('http://trino:8080');
-    await page.locator('div').filter({hasText: /^Impersonate logged in userAccess token$/}).getByLabel('Toggle switch').click();
+    await page.locator('#trino-settings-enable-impersonation').click({ force: true });


This test is not failing on the main branch. Can you remove this change from this PR if there's another one open that fixes it?

nineinchnick · 2025-10-28T15:30:34Z

src/e2e.test.ts


+async function setupDataSourceWithClientTags(page: Page, clientTags: string) {
+    await page.getByTestId('data-testid Datasource HTTP settings url').fill('http://trino:8080');
+    await page.locator('#trino-settings-enable-impersonation').click({ force: true });


I think I already asked, but why force: true is required here? I don't know much about Playwright tests.

Corrected and used the one that was already being used in the line https://github.com/trinodb/grafana-trino/blob/main/src/e2e.test.ts#L24C1-L25C1

laserninja marked this pull request as ready for review July 26, 2025 03:46

cla-bot bot added the cla-signed label Jul 26, 2025

laserninja marked this pull request as draft July 28, 2025 15:50

laserninja marked this pull request as ready for review July 29, 2025 05:06

Flgado mentioned this pull request Sep 2, 2025

Add Client Tags Support trinodb/trino-go-client#155

Merged

jaleed-sudo mentioned this pull request Sep 8, 2025

Data Source Trino: HTTP header not working grafana/grafana#109471

Open

RotRotAl reviewed Sep 18, 2025

View reviewed changes

RotRotAl reviewed Sep 21, 2025

View reviewed changes

RotRotAl mentioned this pull request Sep 25, 2025

Feature/ticketless client tags in query editor #317

Open

laserninja mentioned this pull request Sep 25, 2025

Minor fix in impersonation test case #318

Merged

nineinchnick approved these changes Oct 28, 2025

View reviewed changes

Add Client tags to the Trino Grafana plugin

309c2c8

laserninja force-pushed the main branch from c6d7d51 to 309c2c8 Compare October 28, 2025 16:31

nineinchnick merged commit 7b190bc into trinodb:main Oct 28, 2025
3 checks passed

Add support for passing header X-Trino-Client-Tags #309

Add support for passing header X-Trino-Client-Tags #309

Uh oh!

Conversation

laserninja commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add support for X-Trino-Client-Tags header

Description

How to Use

Technical Details

Testing

References

Uh oh!

cla-bot bot commented Jul 17, 2025

Uh oh!

harksin commented Aug 12, 2025

Uh oh!

jaleed-sudo commented Aug 20, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RoeyoOgen commented Sep 21, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RotRotAl commented Oct 18, 2025

Uh oh!

RotRotAl commented Oct 21, 2025

Uh oh!

laserninja commented Oct 25, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

laserninja commented Jul 17, 2025 •

edited

Loading