Optimize BETWEEN predicate to include both the sides. #22521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix the test @osscm ? |
sopel39
reviewed
Jul 1, 2024
| @@ -88,7 +88,7 @@ private static SortExpressionContext merge(SortExpressionContext left, SortExpre | |||
| } | |||
|
|
|||
| private static class SortExpressionVisitor | |||
| extends IrVisitor<Optional<SortExpressionContext>, Void> | |||
| extends IrVisitor<Optional<List<SortExpressionContext>>, Void> | |||
There was a problem hiding this comment.
Optional is no longer needed, just List<SortExpressionContext>
| @@ -115,7 +115,7 @@ protected Optional<SortExpressionContext> visitComparison(Comparison comparison, | |||
| hasBuildReferencesOnOtherSide = hasBuildSymbolReference(buildSymbols, comparison.right()); | |||
| } | |||
| if (sortChannel.isPresent() && !hasBuildReferencesOnOtherSide) { | |||
| yield sortChannel.map(symbolReference -> new SortExpressionContext(symbolReference, singletonList(comparison))); | |||
| yield sortChannel.map(symbolReference -> singletonList(new SortExpressionContext(symbolReference, singletonList(comparison)))); | |||
core/trino-main/src/main/java/io/trino/sql/planner/SortExpressionExtractor.java
Show resolved
Hide resolved
|
@osscm please squash these two commits together - they are a single logical change |
these 2 tests are failing, so trying to check, if there is any relation with the current PR changes. Rerun of the prb looks them good, could be the flaky one. |
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reviving this old PR
visitBetweenPredicate in SortExpressionVisitor can only handle one side of BETWEEN (GREATER_THAN_OR_EQUAL or LESS_THAN_OR_EQUAL), this pr optimize it and let it handle both sides of BETWEEN as conjunct expressions
Fixes one par of this issue: #22520
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: