Boundary model for open boundaries #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LasNikas
commented
Jul 16, 2024
efaulhaber
requested changes
Jul 18, 2024
src/schemes/boundary/open_boundary/method_of_characteristics.jl
Outdated
Show resolved
Hide resolved
efaulhaber
requested changes
Jul 18, 2024
svchb
requested changes
Jul 18, 2024
svchb
previously approved these changes
Jul 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
=======================================
Coverage ? 69.73%
=======================================
Files ? 76
Lines ? 4573
Branches ? 0
=======================================
Hits ? 3189
Misses ? 1384
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
efaulhaber
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically outsources the evaluation of the characteristic variables in a separate file.
Also, it allows to specify different boundary models for the OBC.
I will create another PR (#574) in which I add the
BoundaryModelTafuni